Skip to content

Adding issuer#2266

Merged
gguuss merged 3 commits into
GoogleCloudPlatform:masterfrom
abbycar:patch-1
Jul 19, 2019
Merged

Adding issuer#2266
gguuss merged 3 commits into
GoogleCloudPlatform:masterfrom
abbycar:patch-1

Conversation

@abbycar

@abbycar abbycar commented Jul 11, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 11, 2019

@gguuss gguuss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a lint error in one of the other files in this project:

flake8 --show-source --builtin gettext --max-complexity 20 --import-order-style google --exclude .nox,.cache,env,lib,generated_pb2,*_pb2.py,*_pb2_grpc.py --ignore=E121,E123,E126,E226,E24,E704,W503,W504,I100,I201,I202 --application-import-names app_engine_app,validate_jwt,make_iap_request,example_gce_backend,iap_test .
./make_iap_request.py:51:1: W293 blank line contains whitespace

Can you get lint passing for the project before we merge?

@gguuss gguuss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gguuss gguuss merged commit 210b7b2 into GoogleCloudPlatform:master Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants