Miscellaneous updates to copy composer environment script.#1919
Merged
Conversation
jmcarp
commented
Dec 8, 2018
jmcarp
commented
Contributor
- Fail fast if required executables missing
- Pass project to storage client
- Set bucket permissions without subprocess
- Handle fuse umount on mac os
googlebot
added
the
cla: yes
* Fail fast if required executables missing * Pass project to storage client * Set bucket permissions without subprocess * Handle fuse umount on mac os
jmcarp
force-pushed
the
copy-composer-fixes
branch
from
e766187 to
6274006
Compare
Contributor
Author
|
cc @engelke |
engelke
approved these changes
Jan 25, 2019
engelke
left a comment
engelke
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Kokoro tests are not running regularly, and are failing for reasons unrelated to this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.