Skip to content

Add try-except example to error reporting#1659

Merged
ace-n merged 4 commits into
masterfrom
fix-b113075902
Sep 11, 2018
Merged

Add try-except example to error reporting#1659
ace-n merged 4 commits into
masterfrom
fix-b113075902

Conversation

@ace-n

@ace-n ace-n commented Aug 27, 2018

Copy link
Copy Markdown

No description provided.

@ace-n ace-n requested a review from andrewsg August 27, 2018 21:07
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 27, 2018
@ace-n ace-n added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 27, 2018
@ace-n

ace-n commented Aug 27, 2018

Copy link
Copy Markdown
Author

Do not merge until we document a way to report exceptions without terminating the function.

@andrewsg

Copy link
Copy Markdown
Member

I'll hold off on this as there's not much to review until the last bit is added.

Change-Id: I8fe091456bad352936d43a7174059c7b3a35721f
@ace-n

ace-n commented Aug 30, 2018

Copy link
Copy Markdown
Author

This should be good to review now. 😄

@ace-n ace-n removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 30, 2018
Ace Nassri added 2 commits August 30, 2018 19:11
Change-Id: I3bace7962c92440d6ac3ac0169ef5ad52e06072b
Change-Id: I42113c49d165d0b04b2ff401b236b3347913c8c8
@ace-n ace-n merged commit a7d63b3 into master Sep 11, 2018
@ace-n ace-n deleted the fix-b113075902 branch September 11, 2018 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants