BigQuery: Updates samples for BigQuery Beta 2 (do not merge until release)#1178
Merged
BigQuery: Updates samples for BigQuery Beta 2 (do not merge until release)#1178
Conversation
googlebot
added
the
cla: yes
tswast
reviewed
Oct 26, 2017
Contributor
tswast
left a comment
tswast
left a comment
There was a problem hiding this comment.
Overall, LGTM. I know you are in class now, so I'll address most of these comments in a new commit to the branch.
| job_name = str(uuid.uuid4()) | ||
| dataset_ref = bigquery_client.dataset(dataset_id) | ||
| table_ref = dataset_ref.table(table_id) | ||
| job_id = str(uuid.uuid4()) |
Contributor
There was a problem hiding this comment.
job_id is optional now that the client library can generate it, so probably can be removed from this sample
| job_name = str(uuid.uuid4()) | ||
| dataset_ref = bigquery_client.dataset(dataset_id) | ||
| table_ref = dataset_ref.table(table_id) | ||
| job_id = str(uuid.uuid4()) |
Contributor
There was a problem hiding this comment.
We can remove this job_id generation.
| ] | ||
| job_config = bigquery.QueryJobConfig() | ||
| job_config.query_parameters = query_params | ||
| job_id = str(uuid.uuid4()) |
Contributor
There was a problem hiding this comment.
We can remove this job_id, too.
| job_id = str(uuid.uuid4()) | ||
| query_job = client.query(query, job_config=job_config, job_id=job_id) | ||
|
|
||
| query_job.result() # Wait for job to complete |
Contributor
There was a problem hiding this comment.
We should use the return value for result instead of getting the table after this.
| job_id = str(uuid.uuid4()) | ||
| query_job = client.query(query, job_config=job_config, job_id=job_id) | ||
|
|
||
| query_job.result() # Wait for job to complete |
Contributor
There was a problem hiding this comment.
Use the rows from the return value for result here.
| job_config.query_parameters = query_params | ||
| query_job = client.query(query, job_config=job_config, job_id=job_id) | ||
|
|
||
| query_job.result() # Waits for job to complete |
Contributor
There was a problem hiding this comment.
Use the return value from result.
| bigquery.ScalarQueryParameter('y', 'STRING', y) | ||
| ) | ||
| ] | ||
| job_id = str(uuid.uuid4()) |
Contributor
There was a problem hiding this comment.
Let the client library generate the job ID.
| job_config.query_parameters = query_params | ||
| query_job = client.query(query, job_config=job_config, job_id=job_id) | ||
|
|
||
| query_job.result() # Waits for job to complete |
Contributor
There was a problem hiding this comment.
Use the return value from result.
| for row in destination_table.fetch_data(): | ||
| print(row) | ||
| for row in results: | ||
| print("{}: {}".format(row.title, row.unique_words)) |
Contributor
There was a problem hiding this comment.
Love it! It's much nicer to show accessing the specific columns in this sample.
bigquery/cloud-client/snippets.py
Outdated
|
|
||
| # Load at most 25 results. | ||
| rows = itertools.islice(table.fetch_data(), 25) | ||
| rows = itertools.islice(bigquery_client.list_rows(table), 25) |
Contributor
There was a problem hiding this comment.
We can actually pass max_results to list_rows now.
Use max_results in list_rows.
tswast
approved these changes
Oct 26, 2017
Contributor
tswast
left a comment
tswast
left a comment
There was a problem hiding this comment.
Ah, I reviewed a second too soon. I see you've addressed the job_id and result changes. Thanks!
tswast
added
the
do not merge
…of outdated 'publicdata'
theacodes
removed
the
do not merge
plamut
pushed a commit
to plamut/python-bigquery
that referenced
this pull request
Jun 25, 2020
…ease) [(googleapis#1178)](GoogleCloudPlatform/python-docs-samples#1178) * updates client.extract_table() sample * updates client.load_table_from_file() sample * updates client.load_table_from_uri() sample * updates parameterized query samples * updates query samples * updates dataset quickstart * fixes typo in sample * updates simple app sample * updates snippets * updates stream data sample * updates user credentials sample * removes job_id generation * Update BQ lib to 0.28.0. Use max_results in list_rows. * updates public dataset queries to use 'bigquery-public-data' instead of outdated 'publicdata' * updates readme and help sections
plamut
pushed a commit
to plamut/python-bigquery
that referenced
this pull request
Jul 22, 2020
…ease) [(googleapis#1178)](GoogleCloudPlatform/python-docs-samples#1178) * updates client.extract_table() sample * updates client.load_table_from_file() sample * updates client.load_table_from_uri() sample * updates parameterized query samples * updates query samples * updates dataset quickstart * fixes typo in sample * updates simple app sample * updates snippets * updates stream data sample * updates user credentials sample * removes job_id generation * Update BQ lib to 0.28.0. Use max_results in list_rows. * updates public dataset queries to use 'bigquery-public-data' instead of outdated 'publicdata' * updates readme and help sections
shollyman
pushed a commit
to googleapis/python-bigquery
that referenced
this pull request
Jul 22, 2020
…ease) [(#1178)](GoogleCloudPlatform/python-docs-samples#1178) * updates client.extract_table() sample * updates client.load_table_from_file() sample * updates client.load_table_from_uri() sample * updates parameterized query samples * updates query samples * updates dataset quickstart * fixes typo in sample * updates simple app sample * updates snippets * updates stream data sample * updates user credentials sample * removes job_id generation * Update BQ lib to 0.28.0. Use max_results in list_rows. * updates public dataset queries to use 'bigquery-public-data' instead of outdated 'publicdata' * updates readme and help sections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.