Conversation
googlebot
added
the
cla: yes
davidcavazos
reviewed
Sep 8, 2017
| if args.use_standard_sql: | ||
| query_standard_sql(args.query) | ||
| elif args.destination_table: | ||
| dataset, table = args.destination_table.split('.') |
There was a problem hiding this comment.
We could use a simple regular expression to validate that the destination table name is in the correct format, i.e. dataset_name.table_name
There was a problem hiding this comment.
However, this being a sample, it might be a better idea to keep unnecessary complexity down. So I'll leave that to you
Contributor
Author
There was a problem hiding this comment.
I'd rather keep the complexity low.
|
Please do whatever you think best for the validation comment, otherwise LGTM |
theacodes
approved these changes
Sep 12, 2017
| # Allow the results table to be overwritten. | ||
| query_job.write_disposition = 'WRITE_TRUNCATE' | ||
|
|
||
| query_job.begin() |
Contributor
There was a problem hiding this comment.
doesn't .result() call .begin()?
Contributor
Author
There was a problem hiding this comment.
Oh, I didn't realize that. I can update the sample if so.
theacodes
approved these changes
Sep 19, 2017
plamut
pushed a commit
to plamut/python-bigquery
that referenced
this pull request
Jun 25, 2020
plamut
pushed a commit
to plamut/python-bigquery
that referenced
this pull request
Jul 22, 2020
shollyman
pushed a commit
to googleapis/python-bigquery
that referenced
this pull request
Jul 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://cloud.google.com/bigquery/docs/writing-results