fix(docker): Hardcoding virtualenv version to keep Python 2.7 support#10479
Merged
Conversation
product-auto-label
Bot
added
the
samples
rsamborski
approved these changes
Jul 28, 2023
Contributor
Author
|
Tests seem to be failing due to quota problems. Should be safe to merge. |
dandhlee
reviewed
Jul 31, 2023
Comment on lines
+93
to
+95
| # Install virtualenv in version 20.21, since version 20.22 no longer supports Python 2.7 | ||
| pip install --user -q virtualenv==20.21 | ||
|
|
Collaborator
There was a problem hiding this comment.
Can we split them for 2.7? There's a runtime specific condition above:
if [[ "${RUN_TESTS_SESSION}" == "py-3.8" ]]; then
dandhlee
approved these changes
Aug 1, 2023
rsamborski
pushed a commit
that referenced
this pull request
Aug 2, 2023
…#10479) * fix(docker): Hardcoding virtualenv version to keep Python 2.7 support * Limiting the virtualenv installation to py-2.7 only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since version 20.22 virtualenv no longer supports Python 2.7. We hardcode virtualenv version to keep Python 2.7 while we work on deprecating it from our repositories.