Skip to content

docs(samples): fix return types and refactor tests to match#10477

Merged
rsamborski merged 2 commits into
GoogleCloudPlatform:mainfrom
irataxy:main
Jul 28, 2023
Merged

docs(samples): fix return types and refactor tests to match#10477
rsamborski merged 2 commits into
GoogleCloudPlatform:mainfrom
irataxy:main

Conversation

@irataxy

@irataxy irataxy commented Jul 28, 2023

Copy link
Copy Markdown
Contributor

Description

Refactor return types and tests to address feedback in #10458 (comment).

Please merge this PR for me once it is approved

@irataxy irataxy requested review from a team as code owners July 28, 2023 01:08
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Jul 28, 2023
@irataxy irataxy assigned rsamborski and unassigned m-strzelczyk Jul 28, 2023

@rsamborski rsamborski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for refactoring these samples to improve our testing landscape.

@rsamborski rsamborski merged commit 84816c5 into GoogleCloudPlatform:main Jul 28, 2023
rsamborski pushed a commit that referenced this pull request Aug 2, 2023
* docs(samples): fix return types and refactor tests to match

* add stitching_policy to config for uniformity in samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants