Skip to content

Fix SQL query to return 10 rows & simplify#1041

Merged
theacodes merged 1 commit intoGoogleCloudPlatform:masterfrom
PicardParis:patch-1
Jul 31, 2017
Merged

Fix SQL query to return 10 rows & simplify#1041
theacodes merged 1 commit intoGoogleCloudPlatform:masterfrom
PicardParis:patch-1

Conversation

@PicardParis
Copy link
Copy Markdown
Member

@PicardParis PicardParis commented Jul 31, 2017

  • Original query returned a single nested row (instead of 10 rows as apparently expected in section print_results)
  • Standard SQL specified directly in query
  • Removed parameter max_results to avoid redundancy w/ query

@PicardParis
Fix SQL query to return 10 rows & simplify
f80a993 
- Original query returned a single nested row (instead of 10 rows as apparently expected in section print_results)
- Standard SQL specified directly in query
- Removed parameter max_results to avoid redundancy w/ query
@googlebot
Copy link
Copy Markdown

googlebot commented Jul 31, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 31, 2017
@PicardParis
Copy link
Copy Markdown
Member Author

PicardParis commented Jul 31, 2017 •
edited
Loading

Added my corporate email in GitHub settings

@theacodes theacodes requested a review from tswast July 31, 2017 15:58
@googlebot
Copy link
Copy Markdown

googlebot commented Jul 31, 2017

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 31, 2017
tswast
tswast approved these changes Jul 31, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@theacodes theacodes merged commit 29ec3d8 into GoogleCloudPlatform:master Jul 31, 2017
@theacodes
Copy link
Copy Markdown
Contributor

theacodes commented Jul 31, 2017

@tswast @PicardParis This caused the system tests to fail. Can one of you send a PR to update the tests?

@PicardParis PicardParis deleted the patch-1 branch August 1, 2017 07:04
@PicardParis
Copy link
Copy Markdown
Member Author

PicardParis commented Aug 1, 2017

Proposed change still gets a PASSED:
simple_app_test.py::test_query_shakespeare PASSED

Failures are related to 2 other tests.
I think I see why. Let me check...

@PicardParis
Copy link
Copy Markdown
Member Author

PicardParis commented Aug 1, 2017

The 2 failures are in fact due to random queries in async_query_test.py and sync_query_test.py.

Proposed fixes in PRs:
#1043
#1044

@theacodes
Copy link
Copy Markdown
Contributor

theacodes commented Aug 1, 2017

@PicardParis thanks!

plamut pushed a commit to plamut/python-bigquery that referenced this pull request Jun 25, 2020
@PicardParis
Fix SQL query to return 10 rows & simplify [(googleapis#1041)](Google…
d50ad1d 
…CloudPlatform/python-docs-samples#1041)

- Original query returned a single nested row (instead of 10 rows as apparently expected in section print_results)
- Standard SQL specified directly in query
- Removed parameter max_results to avoid redundancy w/ query
plamut pushed a commit to plamut/python-bigquery that referenced this pull request Jul 22, 2020
@PicardParis @plamut
Fix SQL query to return 10 rows & simplify [(googleapis#1041)](Google…
5527c56 
…CloudPlatform/python-docs-samples#1041)

- Original query returned a single nested row (instead of 10 rows as apparently expected in section print_results)
- Standard SQL specified directly in query
- Removed parameter max_results to avoid redundancy w/ query
shollyman pushed a commit to googleapis/python-bigquery that referenced this pull request Jul 22, 2020
@PicardParis @shollyman
Fix SQL query to return 10 rows & simplify [(#1041)](GoogleCloudPlatf…
a9268e1 
…orm/python-docs-samples#1041)

- Original query returned a single nested row (instead of 10 rows as apparently expected in section print_results)
- Standard SQL specified directly in query
- Removed parameter max_results to avoid redundancy w/ query
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PicardParis @googlebot @theacodes @tswast