Skip to content

Add Cloud Run Events Samples #3256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 7 commits into from
Jun 25, 2020
Merged

Add Cloud Run Events Samples #3256

gcf-merge-on-green merged 7 commits into from
Jun 25, 2020

Conversation

@averikitsch
Copy link
Contributor

@averikitsch averikitsch commented Jun 25, 2020 •
edited
Loading

Fixes #issue

It's a good idea to open an issue first for discussion.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@averikitsch averikitsch requested review from a team and grant June 25, 2020 19:21
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 25, 2020
grant
grant suggested changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some requested changes.

@averikitsch averikitsch added the automerge Merge the pull request once unit tests and other checks pass. label Jun 25, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit fe4dade into master Jun 25, 2020
@gcf-merge-on-green gcf-merge-on-green bot deleted the events branch June 25, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@grant grant grant approved these changes

@lesv lesv lesv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lesv lesv

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@averikitsch @grant @lesv @googlebot