fix: default to PickFirstLoadBalancerProvider#2063
Merged
lesv merged 5 commits intoFeb 15, 2020
Merged
Conversation
The services/META-INF/io.grpc.LoadBalancerProvider file included by default in the jar with dependencies did not correspond with the default pick_first policy of AutoConfiguredLoadBalancerFactory. Fixes GoogleCloudPlatform#2061
googlebot
added
the
cla: yes
skuruppu
approved these changes
Feb 12, 2020
skuruppu
left a comment
skuruppu
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this. I assume that commands in the getting started guide will still work. I didn't try the change myself.
java -jar target/spanner-google-cloud-samples-jar-with-dependencies.jar \
createdatabase test-instance example-db
Contributor
Author
|
@skuruppu Yes, I tried with the exact steps up until and including the command mentioned above (and in the Getting Started documentation). |
lesv
approved these changes
Feb 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The services/META-INF/io.grpc.LoadBalancerProvider file included by default in the jar with dependencies did not correspond with the default pick_first policy of AutoConfiguredLoadBalancerFactory.
Fixes #2061