fix: Add ORDER BY to guarantee output order#1903
Merged
Merged
Conversation
googlebot
added
the
cla: yes
Contributor
|
Does this affect the meaning of the docs that this sample is used in? |
Contributor
Author
|
No, the meaning of the docs stays the same and is not affected by the additional (The code was also already changed for Node.js as the same problem occurred there) |
averikitsch
approved these changes
Dec 20, 2019
averikitsch
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
ORDER BY SingerId DESCto the sample query to guarantee the order of the returned values. This will fix the failingSpannerSample.queryWithArrayOfStructsample.