bq_update_dataset_expiration sample#1783
Merged
stephaniewang526 merged 3 commits intoDec 4, 2019
Merged
Conversation
googlebot
added
the
cla: yes
kurtisvg
suggested changes
Dec 4, 2019
| updateDatasetExpiration(datasetName, newExpiration); | ||
| } | ||
|
|
||
| public static void updateDatasetExpiration(String datasetName, Long newExpiration) { |
Contributor
There was a problem hiding this comment.
Please inline newExpiration - doesn't look like it's required for testing (see Function Structure)
| public static void runUpdateDatasetExpiration() { | ||
| // TODO(developer): Replace these variables before running the sample. | ||
| String datasetName = "my-dataset-name"; | ||
| Long newExpiration = 24 * 60 * 60 * 1000L; // one day in milliseconds |
Contributor
There was a problem hiding this comment.
Use java.time - see Time.
TimeUnit.MILLISECONDS.convert(1, TimeUnit.DAYS);
kurtisvg
approved these changes
Dec 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.