bq_update_dataset_access#1768
Merged
stephaniewang526 merged 3 commits intoDec 2, 2019
Merged
Conversation
googlebot
added
the
cla: yes
kurtisvg
suggested changes
Nov 27, 2019
| Acl newEntry = Acl.of(new User("sample.bigquery.dev@gmail.com"), Role.READER); | ||
| try { | ||
| acls.add(newEntry); | ||
| DatasetInfo.Builder builder = dataset.toBuilder(); |
Contributor
There was a problem hiding this comment.
Typically builders are used like this:
DatasetInfo dataset = dataset.toBuilder().setAcl(acls).build();| ArrayList<Acl> acls = new ArrayList<>(beforeAcls); | ||
| Acl newEntry = Acl.of(new User("sample.bigquery.dev@gmail.com"), Role.READER); | ||
| try { | ||
| acls.add(newEntry); |
Contributor
There was a problem hiding this comment.
This can be moved out of the try/catch (see above comment). Generally, you should try to limit try/catches around where the exceptions actually occur.
| BigQuery bigquery = BigQueryOptions.getDefaultInstance().getService(); | ||
|
|
||
| Dataset dataset = bigquery.getDataset(datasetName); | ||
| List<Acl> beforeAcls = dataset.getAcl(); |
Contributor
There was a problem hiding this comment.
Does this throw an exception as well? Presumable it's making an API call underneath?
| Dataset dataset = bigquery.getDataset(datasetName); | ||
| List<Acl> beforeAcls = dataset.getAcl(); | ||
|
|
||
| // Make a copy of the ACLs so that they can be modified. |
Contributor
There was a problem hiding this comment.
This is somewhat misleading - you aren't making a copy of the ACLs, you are making a copy of the list (which still has references to the original ACL objects). The references in the list still point to the same objects.
Also, there's no reason to retain a link to the original list, because it doesn't get used anywhere.
Something like this might be better instead:
Suggested change
| // Make a copy of the ACLs so that they can be modified. | |
| // For more information on the types of ACLs available see: | |
| // https://link.to.acl.docs | |
| // Create a new ACL granting the READER role to "sample.bigquery.dev@gmail.com" | |
| Acl newEntry = Acl.of(new Acl.User("sample.bigquery.dev@gmail.com"), Role.READER); | |
| // Get a copy of the ACLs list from the dataset and append the new entry | |
| ArrayList<Acl> acls = new ArrayList<>(dataset.getAcl()); | |
| acls.add(newEntry); | |
| // Then down below add a comment like "Update the dataset to use the new ACLs". |
kurtisvg
approved these changes
Dec 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.