Add BigQueryKmsKey Dataflow sample#1559
Conversation
googlebot
added
the
cla: yes
blunderbuss-gcf
Bot
removed
the
blunderbuss: assign
davidcavazos
force-pushed
the
dataflow-cmek
branch
9 times, most recently
from
c663106 to
c578384
Compare
davidcavazos
force-pushed
the
dataflow-cmek
branch
from
c578384 to
894ec2a
Compare
davidcavazos
force-pushed
the
dataflow-cmek
branch
from
894ec2a to
da35c40
Compare
|
Hi @lesv, can you take a look at this whenever you have a chance? Thanks! |
lesv
left a comment
lesv
left a comment
There was a problem hiding this comment.
Let's talk about this tomorrow, I may ask for a change in the README, but I'm very happy w/ the code.
davidcavazos
left a comment
davidcavazos
left a comment
There was a problem hiding this comment.
I updated some dependency versions as well as the Java version to 11. I also updated the templates pom.xml file to follow the same format as the one in encryption-keys just for consistency.
davidcavazos
force-pushed
the
dataflow-cmek
branch
from
503ad33 to
f9f6ba0
Compare
|
@davidcavazos Apache Beam does not have full support for Java 11. The Polidea team is still working on it. Does Dataflow Runner fully support Jave 11? I am not sure if we should use this version. |
|
Hi @mik-laj, although Apache Beam SDK itself isn't in Java 11 yet, the package can still be used by Java 11 applications. I would go ahead and try to stick with the latest Java version while the Beam SDK catches up. This would mean not having to migrate from one version to another once the old version drops support (like what happened with Python 2), which we've seen can be a huge effort. I haven't run into any issues by using Java 11, so I would still recommend using the latest version to try to keep up to date. |
5 participants
Creating a Dataflow sample to show how to use Customer-Managed Encryption Keys (CMEK) for the Using customer-managed encryption keys docs page.
Also updating the templates README for consistency.