Skip to content

Fixes classnames in inline documentation#1527

Merged
gguuss merged 18 commits into
masterfrom
iot-fix-comment-docs
Jul 30, 2019
Merged

Fixes classnames in inline documentation#1527
gguuss merged 18 commits into
masterfrom
iot-fix-comment-docs

Conversation

@gguuss

@gguuss gguuss commented Jul 25, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@gguuss gguuss requested a review from a team July 25, 2019 20:36
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 25, 2019

@lesv lesv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

@lesv lesv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to try it, as there is sometimes some changes you need in pom.xml

LGTM if it works.

@gguuss

gguuss commented Jul 25, 2019

Copy link
Copy Markdown
Contributor Author

I'll merge once verifying all the commands work as expected.

@gguuss

gguuss commented Jul 25, 2019

Copy link
Copy Markdown
Contributor Author

Looks like a few updates will be necessary :)

@gguuss gguuss added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 25, 2019
@gguuss

gguuss commented Jul 26, 2019

Copy link
Copy Markdown
Contributor Author

@lesv I'm concerned that moving to mvn exec:exec is adding a lot of complexity to the sample. To translate 1 of the 3 command line runners (the simple one) to exec:exec has added 100 lines of XML and required careful revision to the run arguments because it does not support passing a complete ARGV to the main Java class and instead requires each individual parameter be passed as variables to mvn exec.

For this PR, I'll be skipping translating the other samples for IoT to this pattern as it will be too much code for a sensible PR.

@lesv

lesv commented Jul 26, 2019

Copy link
Copy Markdown
Contributor

@gguuss I wasn't expecting you to do all of them. I understood it was annoying and difficult. #1524 was opened for this process.

@gguuss

gguuss commented Jul 26, 2019

Copy link
Copy Markdown
Contributor Author

#1524 was opened for this process.

SGTM, I'll start keeping some notes :) I understand a few advantages of exec:exec it's just a little more verbose.

@gguuss gguuss merged commit fa3c58b into master Jul 30, 2019
@gguuss gguuss deleted the iot-fix-comment-docs branch July 30, 2019 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants