Fix OpenCensus thread cleanup error and other issues.#1246
Merged
Conversation
googlebot
added
the
cla: yes
kurtisvg
approved these changes
Nov 1, 2018
mtabasko
reviewed
Nov 1, 2018
mtabasko
left a comment
mtabasko
left a comment
Contributor
There was a problem hiding this comment.
Dane, these look good to me. I really can't decide whether I want tags around imports right now, so I'm just gonna let it go for now. We can always revisit later if needed.... thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenCensus rep tried running the sample and had some feedback.
pom.xml- without it, the program does not end gracefully.