Skip to content

fix(container-registry): remove duplicate region_tag dependencies#10292

Open
Kef131 wants to merge 1 commit into
mainfrom
fix(container-registry)-remove-duplicate-regiontags-dependencies
Open

fix(container-registry): remove duplicate region_tag dependencies#10292
Kef131 wants to merge 1 commit into
mainfrom
fix(container-registry)-remove-duplicate-regiontags-dependencies

Conversation

@Kef131

@Kef131 Kef131 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #
b/527027927

Clean up duplicate and generic "dependencies" region tags in container-registry samples.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: containeranalysis Issues related to the Container Analysis API. labels Jun 25, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes region tag comments, specifically the start and end dependency tags, from the pom.xml file in the container-registry/container-analysis directory. There are no review comments, and I have no feedback to provide.

@XrossFox XrossFox left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kef131 Kef131 marked this pull request as ready for review June 26, 2026 18:10
@Kef131 Kef131 requested review from a team and yoshi-approver as code owners June 26, 2026 18:10
@snippet-bot

snippet-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: containeranalysis Issues related to the Container Analysis API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants