Skip to content

fix(media): remove duplicate region_tag dependencies#10291

Draft
Kef131 wants to merge 1 commit into
mainfrom
fix(media)-duplicate-regiontag-dependencies
Draft

fix(media): remove duplicate region_tag dependencies#10291
Kef131 wants to merge 1 commit into
mainfrom
fix(media)-duplicate-regiontag-dependencies

Conversation

@Kef131

@Kef131 Kef131 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #
b/527028805

Clean up duplicate and generic "dependencies" region tags in media samples (media/transcoder/pom.xml).

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required (failed locally due to storage permissions issues in the current GCP credentials environment)
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only (failed compiler plug-in execution due to JDK 25 and ErrorProne incompatibility)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: transcoder Issues related to the Transcoder API API. labels Jun 25, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 25, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the region tag comments [START dependencies] and [END dependencies] from the pom.xml file in the media/transcoder directory. There are no review comments, and I have no feedback to provide.

@Kef131 Kef131 changed the title chore: remove unnecessary dependency documentation tags in pom.xml fix(media): remove duplicate region_tag dependencies Jun 25, 2026
@Kef131 Kef131 self-assigned this Jun 25, 2026
@product-auto-label product-auto-label Bot added api: mediatranslation Issues related to the Media Translation API. and removed api: transcoder Issues related to the Transcoder API API. labels Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver will be requested when the pull request is marked ready for review yoshi-approver is a code owner
1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@Kef131 Kef131

Labels

api: mediatranslation Issues related to the Media Translation API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Kef131