feat: add Cloud Run samples for Java25 #10198
Conversation
product-auto-label
bot
added
the
samples
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @maigovannon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new 'Hello World' sample application built with Spring Boot, designed for deployment on Google Cloud Run using source-based builds. This addition aims to provide a clear, runnable example for developers looking to get started with Java applications on Cloud Run. Concurrently, an existing Maven project's compiler settings have been updated to support a newer Java version. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new helloworld-source sample for Cloud Run and updates the Java compiler version for the existing helloworld sample. I've identified a few issues that need attention. Both samples are configured to use Java 25, which is an unreleased version and should be changed to a stable LTS version like 17 or 21. The new sample also references a non-existent Spring Boot version, which will cause build failures. Additionally, the new sample uses JUnit 4, whereas JUnit 5 is the standard for Spring Boot 3; I've provided suggestions to migrate. There are also a couple of smaller issues regarding a broken link in the new README and a code organization suggestion for the controller.
run/helloworld-source/src/main/java/com/example/helloworld/HelloworldApplication.java
Show resolved
Hide resolved
run/helloworld-source/src/test/java/com/example/helloworld/HelloworldApplicationTests.java
Show resolved
Hide resolved
maigovannon
changed the title
Description
Creating Java25 doc samples for Cloud Run and updating some of the existing ones to Java21. These changes are forked from the bigger PR #10193
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only