feat: add GAE Flex samples for Java25 #10196
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
product-auto-label
bot
added
samples
Summary of ChangesHello @maigovannon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the collection of Java samples for Google App Engine Flexible Environment by adding two new applications. One is a basic Micronaut 'Hello World' service, and the other is a robust example of WebSocket implementation using Jetty. These additions provide developers with more diverse patterns and frameworks for building and deploying applications on App Engine Flex. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds two new App Engine flexible environment samples for Java. My review focuses on several areas for improvement. Both samples are in a java-25 directory, but use Java 21 and 17 respectively, which is misleading. The Micronaut sample has an incorrect runtime configuration in app.yaml and uses an outdated testing approach. The WebSocket sample has several critical issues, including incorrect documentation, configuration mismatches that will cause runtime errors, a memory leak, and improper resource management. I've provided detailed comments and suggestions to address these points.
...e/java-25/websocket-jetty/src/main/java/com/example/flexible/websocket/jettynative/Main.java
Outdated
Show resolved
Hide resolved
...25/websocket-jetty/src/main/java/com/example/flexible/websocket/jettynative/SendServlet.java
Show resolved
Hide resolved
...5/websocket-jetty/src/main/java/com/example/flexible/websocket/jettynative/ClientSocket.java
Show resolved
Hide resolved
...bsocket-jetty/src/test/java/com/example/flexible/websocket/jettynative/ClientSocketTest.java
Show resolved
Hide resolved
...le/java-25/micronaut-helloworld/src/test/java/com/example/appengine/HelloControllerTest.java
Show resolved
Hide resolved
...5/websocket-jetty/src/main/java/com/example/flexible/websocket/jettynative/ClientSocket.java
Show resolved
Hide resolved
maigovannon
changed the title
There was a problem hiding this comment.
This file change really belongs in #10195 but added here by mistake. But pls review it here.
…21 since java25 is not yet stable in Micronaut and Websocket Jetty ecosystem.
Description
Creating Java25 doc samples for GAE Flexible and updating some of the existing ones to Java21. These changes are forked from the bigger PR #10193.
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only