Skip to content

feat: add GAE Standard samples for Java25 #10195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: add GAE Standard samples for Java25 #10195

wants to merge 4 commits into from
+1,400 −0

Conversation

@maigovannon
Copy link

@maigovannon maigovannon commented Nov 3, 2025 •
edited
Loading

Description

Creating Java25 doc samples for Cloud Run and updating some of the existing ones to Java21. These are forked changes from #10193

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only

@maigovannon maigovannon requested review from a team and yoshi-approver as code owners November 3, 2025 11:35
@snippet-bot
Copy link

snippet-bot bot commented Nov 3, 2025 •
edited
Loading

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 3, 2025
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 3, 2025

Summary of Changes

Hello @maigovannon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers a comprehensive set of new sample applications for the Google App Engine Standard environment, specifically tailored for Java 25. The samples aim to provide up-to-date, practical examples for developers, showcasing how to build and deploy applications using the latest Java runtime while accommodating both Jakarta EE 8 and Jakarta EE 11 specifications. These additions will help users quickly adopt and leverage modern Java features within their App Engine projects.

Highlights

  • New Java 25 Samples: This pull request introduces a suite of new sample applications specifically designed for the Google App Engine Standard environment, targeting the Java 25 runtime.
  • Dual Jakarta EE Support: The Google Analytics sample is provided in two distinct versions, demonstrating compatibility with both Jakarta EE 8 (using javax.* packages) and Jakarta EE 11 (using jakarta.* packages) servlet specifications.
  • Flexible Build Tooling: Both Maven and Gradle build configurations are included for the new samples, offering developers flexibility in their preferred build environment.
  • Core Functionality Showcase: The samples cover fundamental App Engine capabilities, including a basic 'Hello World' application and an integration example with Google Analytics.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 3, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds new App Engine samples for Java 25, for both EE8, EE11, and a general helloworld application. The contribution is valuable, but there are several issues, many of which seem to stem from copying older samples without updating all necessary parts. I've found incorrect version numbers for dependencies and XML schemas, broken links in READMEs, and inconsistent code region tags. More critically, there are configuration errors in helloworld/src/main/webapp/WEB-INF/web.xml that would cause deployment to fail, and a security issue in the analytics servlets where HTTP is used instead of HTTPS. My review includes detailed comments and suggestions to address these points and improve the quality and correctness of the new samples.

@maigovannon maigovannon requested review from iennae and ludoch November 3, 2025 12:05
@maigovannon maigovannon changed the title feat: add appengine-java25 samples feat: add GAE Standard samples for Java25 Nov 3, 2025
@maigovannon maigovannon added the api: appengine Issues related to the App Engine Admin API API. label Nov 3, 2025
@maigovannon maigovannon mentioned this pull request Nov 3, 2025
Closed
6 tasks
@maigovannon
Update jacoco-maven-plugin to 0.8.14 and maven-war-plugin to 3.4.0
52baa81 
Add maven-failsafe-plugin with version 3.3.1
@maigovannon maigovannon mentioned this pull request Nov 3, 2025
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

@ludoch ludoch Awaiting requested review from ludoch

@iennae iennae Awaiting requested review from iennae

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@SarthakAjmera26 SarthakAjmera26

Labels

api: appengine Issues related to the App Engine Admin API API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maigovannon @SarthakAjmera26