Pytest refactor #37
Merged
Pytest refactor #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring 2-structured-data tests to use py.test
Refactoring 3-binary-data tests to use py.test
Also: * Fixing bug in model_cloudsql.from_sql that caused None to be cast to literal string 'None'. * Fixing bug where flaky_filter wasn't working as expected.
Refactoring step 4 to use py.test
Updating 5-logging to use py.test
Updating 6-pubsub to use py.test
…remainder Copying 6-pubsub tests into remaining steps
Use nox as the top-level test runner, use gcprepotools for req sessions
Deflaking tests by refactoring the model fixture.
Adding a global nox lint session.
…essions Adding nox sessions to run tests on jenkins and travis
googlebot
added
the
cla: yes
4-auth/bookshelf/model_cloudsql.py
Outdated
|
|
||
|
|
||
| def create(data): | ||
| print(data) |
Contributor
There was a problem hiding this comment.
intentional debug statements or accidental commit?
Contributor
|
lgtm if you want to merge, but I need some help getting the tests working locally. I think we should at least create an issue to document running the tests better. |
Author
|
@waprin definitely want to make sure you can run locally first. We can chat after Next on getting that setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@waprin this is the culmination of all the reviews you've been doing. This is the final merge into master.