Use nox as the top-level test runner, use gcprepotools for req sessions #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
theacodes
force-pushed
the
pytest-refactor-nox
branch
7 times, most recently
from
378e326 to
6e329ad
Compare
theacodes
changed the title
| # Copyright 2015 Google Inc. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. |
Contributor
There was a problem hiding this comment.
I'm confused why this is part of this PR.
Author
There was a problem hiding this comment.
It had a diffbase, hold on, let me update now that the other PR is merged.
theacodes
force-pushed
the
pytest-refactor-nox
branch
from
6e329ad to
e0ebd5b
Compare
| # Unit test / coverage reports | ||
| htmlcov/ | ||
| .tox/ | ||
| .nox/ |
Contributor
There was a problem hiding this comment.
super nit - can get rid of .tox here
Author
There was a problem hiding this comment.
Unfortunately we can't, because the individual steps still use tox and will create .tox folders. ;)
Contributor
|
lgtm |
theacodes
pushed a commit
that referenced
this pull request
Mar 3, 2016
Use nox as the top-level test runner, use gcprepotools for req sessions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: has #32 as a diffbase (until it gets merged).