Create in-solidarity.yml#782
Merged
Merged
Conversation
Initial rules
JustinBeckwith
approved these changes
Sep 26, 2020
JustinBeckwith
left a comment
Contributor
There was a problem hiding this comment.
LGTM! I'd really like to keep the config in github.com/GoogleCloudPlatform/.github if we decide to use it in a second repository so we don't have to duplicate it :)
Contributor
Author
|
@JustinBeckwith PTAL |
Contributor
Author
|
Note, these are in addition to the default rules. |
kurtisvg
approved these changes
Sep 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initial set of rules - we can also add regex's. If there are any you'd suggest we remove, let me know.