Convert legacy GCF events to CloudEvents#285
Merged
matthewrobertson merged 4 commits intomasterfrom May 13, 2021
Merged
Conversation
matthewrobertson
force-pushed
the
l-to-ce-conversion
branch
from
85c870f to
9eb6e90
Compare
grant
approved these changes
May 13, 2021
mtraver
approved these changes
May 13, 2021
mtraver
left a comment
mtraver
left a comment
There was a problem hiding this comment.
Looks great (% Grant's comments)! Thanks :)
matthewrobertson
added a commit
that referenced
this pull request
Jun 3, 2021
This reverts commit d6cabe7.
matthewrobertson
added a commit
that referenced
this pull request
Jun 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds express middleware to convert legacy GCF requests to the equivalent CloudEvent requests. This enables developers to leverage cloud events in functions that consume events from GCP products that don't yet produce CloudEvents.