Skip to content

Conversation

@anniefu
Copy link
Contributor

@anniefu anniefu commented Sep 7, 2022

This creates PRs that can be merged to create GitHub Releases for each of the components of Functions Framework Java.

Every release creates two PRs:

  1. A "release" PR (example) that updates the pom.xml with the next major version number
  2. Once that is merged, a "snapshot" PR (example) that updates the pom.xml with a snapshot version number for the next development iteration

The PRs need to be merged manually.

This creates PRs that can be merged to create GitHub Releases for each
of the components of Functions Framework Java.
@jihuin
Copy link
Contributor

jihuin commented Sep 8, 2022

The example release PR updated the minor version. Is it possible to release patch version every time?

@kappratiksha
Copy link
Contributor

The first PR should just remove the word "SNAPSHOT" from the version and not change any numbers and the second one should update the number and add the word "SNAPSHOT", right? Or am I missing anything?

@jihuin
Copy link
Contributor

jihuin commented Sep 8, 2022

The first PR should just remove the word "SNAPSHOT" from the version and not change any numbers and the second one should update the number and add the word "SNAPSHOT", right? Or am I missing anything?

That's also my understanding.

@anniefu
Copy link
Contributor Author

anniefu commented Sep 8, 2022

Release please uses conventional commits to determine the correct semantic version of the next release: https://github.com/googleapis/release-please#how-should-i-write-my-commits

The two example PRs in the description were formed using fake feat: or fix: commits for testing, and they are for differnet components with unrelated version numbers. Release PRs remove the "SNAPSHOT" as expected, and can also increment the semantic version as appropriate based off conventional commits.

The second "snapshot" commit will always just do a patch increment and add "-SNAPSHOT" again. The version for the next release will be determined by the next "release" PR.

"release" PRs are constantly updated by the Release Please bot based off new commits to master.

@kappratiksha kappratiksha self-requested a review September 8, 2022 00:54
@anniefu anniefu merged commit 06d3f44 into GoogleCloudPlatform:master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants