testing: add integration testing for pymysql driver support - #39
Merged
Conversation
shubha-rajan
force-pushed
the
mysql-system-tests
branch
from
February 2, 2021 18:09
4089231 to
c1ce974
Compare
kurtisvg
approved these changes
Feb 2, 2021
kurtisvg
left a comment
kurtisvg
left a comment
Contributor
There was a problem hiding this comment.
A couple of the renamed files have some stutter we can probably remove (e.g. "tests/test_something_unit.py" -> "tests/unit/test_something_unit.py"). Can we remove the extra "unit"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a system test for using the connector with
pymysql, similar to the integration tests for the Java connector