Skip to content

chore: add kokoro configs - #36

Merged
shubha-rajan merged 5 commits into
masterfrom
kokoro-setup
Feb 1, 2021
Merged

chore: add kokoro configs#36
shubha-rajan merged 5 commits into
masterfrom
kokoro-setup

Conversation

@shubha-rajan

@shubha-rajan shubha-rajan commented Jan 29, 2021

Copy link
Copy Markdown
Contributor

Adding kokoro configs for linting, as well as unit tests in python 3.6-3.9
Fixes #28

@kurtisvg

Copy link
Copy Markdown
Contributor

Is there a matching CL for this?

@shubha-rajan

Copy link
Copy Markdown
Contributor Author

Is there a matching CL for this?

Yes, cl/354551583

Comment thread .kokoro/lint/common.cfg
@@ -0,0 +1,41 @@
# Copyright 2020 Google LLC

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2021 on these?

Comment thread .kokoro/lint/common.cfg Outdated

env_vars: {
key: "TRAMPOLINE_IMAGE"
value: "gcr.io/cloud-devrel-kokoro-resources/python-multi"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer a stock python image if possible.

@shubha-rajan shubha-rajan added kokoro:force-run do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Feb 1, 2021
@shubha-rajan shubha-rajan reopened this Feb 1, 2021
@shubha-rajan shubha-rajan removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. kokoro:force-run labels Feb 1, 2021
@shubha-rajan
shubha-rajan merged commit 6a32512 into master Feb 1, 2021
@jackwotherspoon
jackwotherspoon deleted the kokoro-setup branch August 29, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix travis / continuous testing

2 participants