How'd you go with this?

We're looking at moving to cloud-sql-python connector, but are heavily dependant on asyncpg at the moment.

From what I can gather from a quick gaze, is that we need to skip the custom _create_ssl_connection that gets called when a SSL Context is passed in with the connection args tlsproxy=True.

# asyncpg.connection.connect:


async def connect(
    dsn=None, 
    *,
    # ... other kwargs ... 
    tls_proxy=None # NOTE: new_field
):

# ... gets passed into asyncpg.connect_utils._connect ...

# which calls _parse_connect_arguments:

def _parse_connect_arguments(
    *,
    # ... other kwargs ...
    tls_proxy # NOTE: new_field
):

# ... gets passed into asyncpg.connect_utils._connect_addr ...

# which could look something like this:

async def __connect_addr(
    params,
    timeout,
    retry,
    addr,
    loop,
    config,
    connection_class,
    record_class,
    params_input,
):
    connected = _create_future(loop)

    proto_factory = lambda: protocol.Protocol(
        addr, connected, params, record_class, loop)

    if isinstance(addr, str):
        # UNIX socket
        connector = loop.create_unix_connection(proto_factory, addr)
    # NOTE: new_code
    elif params.ssl and params.tls_proxy:
        # passing ctx, to asyncio.events.create_connection,
        # bypassing asyncpg's _create_ssl_connection
        connector = loop.create_connection(
            proto_factory, *addr, ssl=params.ssl
        )

    elif params.ssl:
        connector = _create_ssl_connection(
            proto_factory, *addr, loop=loop, ssl_context=params.ssl,
            ssl_is_advisory=params.sslmode == SSLMode.prefer)
    else:
        connector = loop.create_connection(proto_factory, *addr)

Uh oh!

Add support for asyncpg driver. #218

Description

Activity

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions