feat: scaffold Windows 7-zip benchmark - #7038
Open
amarkdotdev wants to merge 2 commits into
Open
Conversation
Fixes GoogleCloudPlatform#5250 Signed-off-by: Aaron <amark@g.jct.ac.il>
|
|
||
| FLAGS = flags.FLAGS | ||
|
|
||
| BENCHMARK_NAME = 'seven_benchmark' |
Contributor
There was a problem hiding this comment.
nit: seven_zip_benchmark
|
|
||
| BENCHMARK_NAME = 'seven_benchmark' | ||
| BENCHMARK_CONFIG = """ | ||
| seven_benchmark: |
Contributor
There was a problem hiding this comment.
nit: seven_zip_benchmark
|
|
||
| from absl import flags | ||
| from perfkitbenchmarker import configs | ||
| from perfkitbenchmarker import vm_util |
|
|
||
| def Prepare(benchmark_spec): | ||
| del benchmark_spec | ||
| return [] |
Contributor
There was a problem hiding this comment.
Prepare does not return anything https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/blob/master/perfkitbenchmarker/pkb.py#L22C1-L22C8
|
|
||
| def Cleanup(benchmark_spec): | ||
| del benchmark_spec | ||
| return [] |
Contributor
There was a problem hiding this comment.
Signed-off-by: Aaron <amark@g.jct.ac.il>
Author
|
renamed to seven_zip_benchmark, dropped the unused import, and fixed Prepare/Cleanup signatures |
Comment on lines
+1
to
+46
| # Copyright 2026 PerfKitBenchmarker Authors. All Rights Reserved. | ||
| """7-Zip LZMA benchmark for Windows.""" | ||
|
|
||
| from absl import flags | ||
| from perfkitbenchmarker import configs | ||
|
|
||
| FLAGS = flags.FLAGS | ||
|
|
||
| BENCHMARK_NAME = 'seven_zip_benchmark' | ||
| BENCHMARK_CONFIG = """ | ||
| seven_zip_benchmark: | ||
| description: Runs the 7-Zip LZMA benchmark on Windows. | ||
| vm_groups: | ||
| default: | ||
| vm_spec: | ||
| GCP: | ||
| machine_type: n1-standard-4 | ||
| zone: us-central1-b | ||
| image: windows-2022 | ||
| AWS: | ||
| machine_type: m5.xlarge | ||
| zone: us-east-1 | ||
| image: windows-2022 | ||
| Azure: | ||
| machine_type: Standard_D4s_v5 | ||
| zone: eastus | ||
| image: windows-2022 | ||
| vm_count: 1 | ||
| """ | ||
|
|
||
|
|
||
| def GetConfig(user_config): | ||
| return configs.LoadConfig(BENCHMARK_CONFIG, user_config, BENCHMARK_NAME) | ||
|
|
||
|
|
||
| def Prepare(benchmark_spec): | ||
| del benchmark_spec | ||
|
|
||
|
|
||
| def Run(benchmark_spec): | ||
| del benchmark_spec | ||
| return [] | ||
|
|
||
|
|
||
| def Cleanup(unused_benchmark_spec): | ||
| pass |
Contributor
There was a problem hiding this comment.
nit I don't know if you ran the linter yet but it should complain on 'Final newline missing'. Need 1 more newline.
Contributor
There was a problem hiding this comment.
Pls make sure the linter passes :)
jellyfishcake
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5250
Test plan