Implement fluid physics changes #1062
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not needed, because to tell if a block is waterloggable, you can simply check if its block data is an instance of Waterlogged
clabe45
force-pushed
the
fluid-physics
branch
from
ae70f4c to
2eb3794
Compare
clabe45
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This code is untested (because the tests and server can't be run currently).
Waterlogging
I let blocks get waterlogged where air or water would have become a water source block. Additionally, all the functionality that deals with water in the class now treats waterlogged blocks as water source blocks (using
isLiquid,getType, andgetStrength).Bubble columns
Magma and soul sand create bubble columns, and water propagates or ends them.
Since blockdata hasn't been implemented for 1.13, I wrote print statements where the blockdata should be updated.