Skip to content

Add new PHP format #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Dec 28, 2023
Merged

Add new PHP format #1626

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
e963a57
Add new PHP format
swissspidy May 10, 2023
a85b919
Ignore warning
swissspidy May 10, 2023
4a9651b
Merge branch 'develop' into try/format-php
swissspidy Sep 22, 2023
323b2dc
Update code
swissspidy Sep 22, 2023
d064d18
Update test
swissspidy Sep 22, 2023
30eba58
Use `x-generator` as the header name
swissspidy Sep 23, 2023
d0d5ff1
Merge branch 'develop' into try/format-php
swissspidy Sep 26, 2023
f42b528
Merge branch 'develop' into try/format-php
swissspidy Oct 2, 2023
bb0ccd5
Remove extra typing
swissspidy Oct 3, 2023
03c20cd
Merge branch 'develop' into try/format-php
swissspidy Oct 17, 2023
de90270
Merge branch 'develop' into try/format-php
swissspidy Nov 8, 2023
471158a
Fix messages format
swissspidy Dec 18, 2023
5af3b26
Fix spacing
swissspidy Dec 18, 2023
59e1168
Clean up tests as per code review
swissspidy Dec 20, 2023
fc872c9
Remove php format from import dropdown
swissspidy Dec 20, 2023
f16ca98
Also update `gp_get_import_file_format`
swissspidy Dec 20, 2023
fcea88f
Add new headers to exported file
swissspidy Dec 20, 2023
b96bb39
Skip php import test
swissspidy Dec 20, 2023
5ea9dcf
Use separate filter
swissspidy Dec 22, 2023
4bb6c79
Remove now errant conment
swissspidy Dec 22, 2023
dee69ba
Update extension
swissspidy Dec 22, 2023
56700d3
Merge branch 'develop' into try/format-php
swissspidy Dec 22, 2023
b221502
Update tests
swissspidy Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Also update gp_get_import_file_format
  • Loading branch information
@swissspidy
swissspidy committed Dec 20, 2023
commit f16ca98de0779424820f714934d19a535b22431b
7 changes: 5 additions & 2 deletions gp-includes/misc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,12 +543,15 @@ function gp_gmt_strtotime( $string ) {
* @return object|null A GP_Format child object or null if not found.
*/
function gp_get_import_file_format( $selected_format, $filename ) {
$format = gp_array_get( GP::$formats, $selected_format, null );
$formats = GP::$formats;
unset( $formats['php'] ); // Remove PHP format from the list of formats until we have an import process.

$format = gp_array_get( $formats, $selected_format, null );

if ( ! $format ) {
$matched_ext_len = 0;

foreach ( GP::$formats as $format_entry ) {
foreach ( $formats as $format_entry ) {
$format_extensions = $format_entry->get_file_extensions();

foreach ( $format_extensions as $extension ) {
Expand Down