Add failing test

nikic · nikic · commit eebd857985ce · 2021-07-01T10:28:39.000+02:00
diff --git a/Zend/tests/type_declarations/intersection_types/variance/invalid3.phpt b/Zend/tests/type_declarations/intersection_types/variance/invalid3.phpt
@@ -0,0 +1,18 @@
+--TEST--
+Replacing int type with intersection type
+--FILE--
+<?php
+
+interface X {}
+interface Y {}
+
+class Test {
+    function method(): int {}
+}
+class Test2 extends Test {
+    function method(): X&Y {}
+}
+
+?>
+--EXPECTF--
+Fatal error: Declaration of Test2::method(): X&Y must be compatible with Test::method(): int in %s on line %d
diff --git a/Zend/tests/type_declarations/intersection_types/variance/valid7.phpt b/Zend/tests/type_declarations/intersection_types/variance/valid7.phpt
@@ -0,0 +1,19 @@
+--TEST--
+Replacing object type with intersection type
+--FILE--
+<?php
+
+interface X {}
+interface Y {}
+
+class Test {
+    function method(): object {}
+}
+class Test2 extends Test {
+    function method(): X&Y {}
+}
+
+?>
+===DONE===
+--EXPECTF--
+TODO
diff --git a/Zend/zend_inheritance.c b/Zend/zend_inheritance.c
@@ -595,6 +595,17 @@ static inheritance_status zend_perform_covariant_type_check(
 	bool have_unresolved = false;
 
 	if (ZEND_TYPE_IS_INTERSECTION(fe_type)) {
+		if (proto_type_mask & MAY_BE_OBJECT) {
+			/* TODO We can't just return success here, because the class must be loaded. */
+		}
+		if (proto_type_mask & MAY_BE_ITERABLE) {
+			/* TODO */
+		}
+		if (proto_type_mask) {
+			/* An intersection type cannot be a subtype of other builtin types. */
+			return INHERITANCE_ERROR;
+		}
+
 		/* U_1&...&U_n < V_1&...&V_m if forall V_j. exists U_i. U_i < V_j.
 		 * U_1&...&U_n < V_1|...|V_m if exists V_j. exists U_i. U_i < V_j.
 		 * As such, we need to iterate over proto_type (V_j) first and use a different
@@ -612,8 +623,6 @@ static inheritance_status zend_perform_covariant_type_check(
 				proto_ce = ZEND_TYPE_CE(*single_type);
 				proto_class_name = proto_ce->name;
 			} else {
-				/* standard type */
-				ZEND_UNREACHABLE();
 				continue;
 			}
 
