Skip to content

Common module - #35

Closed
carterhudson wants to merge 1 commit into
update_for_ui_componentsfrom
common_module
Closed

Common module#35
carterhudson wants to merge 1 commit into
update_for_ui_componentsfrom
common_module

Conversation

@carterhudson

@carterhudson carterhudson commented Jan 18, 2021

Copy link
Copy Markdown
Contributor

It was really tedious duplicating updates across resource files for the Kotlin & Java projects, so I extracted the common resources & dependencies to a common module. If we don't want to do this, we can kill this PR.

(won't build on CI until GetStream/stream-chat-android#1229 is merged and stream dependency is updated)

@carterhudson
carterhudson requested a review from a team January 18, 2021 22:53
@carterhudson
carterhudson changed the base branch from master to update_for_ui_components January 18, 2021 22:53
@adasiewiczr

Copy link
Copy Markdown
Contributor

I'm not sure if we should do that - copying resources is annoying but I think that most of the users expect that tutorial is as easy and straightforward as possible (so they can open a project and copy everything from one module). We also had a common dependencies configuration for both modules but we get rid of it to simplify things.

@carterhudson

carterhudson commented Jan 19, 2021

Copy link
Copy Markdown
Contributor Author

I'm not sure if we should do that - copying resources is annoying but I think that most of the users expect that tutorial is as easy and straightforward as possible (so they can open a project and copy everything from one module). We also had a common dependencies configuration for both modules but we get rid of it to simplify things.

That's fair, and I also had that concern, but do we ever link to the tutorial github anywhere? I'm under the impression that this is a repository for us, and we use its contents to curate the tutorial, since I can't find a link to this repo anywhere on the tutorial page.

@zsmb13

zsmb13 commented Jan 19, 2021

Copy link
Copy Markdown
Contributor

If we don't link it anywhere, it's time to add a link to the start and end of the tutorial so that people can check out a working project if they want to 😉

@adasiewiczr

Copy link
Copy Markdown
Contributor

I thought it's linked 🙈 We should definitely add it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants