Skip to content

Compile widget after382 #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ryanwoldatwork merged 4 commits into from
Aug 22, 2024
Merged

Compile widget after382 #1549

ryanwoldatwork merged 4 commits into from
Aug 22, 2024

Conversation

@ryanwoldatwork
Copy link
Contributor

@ryanwoldatwork ryanwoldatwork commented Aug 16, 2024

No description provided.

@ryanwoldatwork ryanwoldatwork requested a review from sanason August 16, 2024 04:17
sanason
sanason reviewed Aug 16, 2024
View reviewed changes
Copy link
Contributor

@sanason sanason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update the USWDS assets used by the Touchpoints app (run npx gulp updateUswds)?

@ryanwoldatwork
Copy link
Contributor Author

ryanwoldatwork commented Aug 16, 2024

ya, if there's a conventional way to run the tasks

@sanason
Copy link
Contributor

sanason commented Aug 20, 2024

npx gulp updateUswds updates the assets for the Touchpoints app.

https://github.com/GSA/touchpoints/wiki/Developer-Guide#updating-uswds

sanason
sanason suggested changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@sanason sanason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'll cause confusion if we don't update both the app and widget when we upgrade the USWDS version.

https://github.com/GSA/touchpoints/wiki/Developer-Guide#updating-uswds

@ryanwoldatwork
Copy link
Contributor Author

ryanwoldatwork commented Aug 21, 2024

I added a npm script updateUswds to run all the commands.

Doing so yielded the following diff.
But it looks like that can all be ignored. Thoughts?

fsddsfsdasfdfsa

sanason
sanason approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@sanason sanason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ryanwoldatwork ryanwoldatwork merged commit ec6495d into develop Aug 22, 2024
@ryanwoldatwork ryanwoldatwork deleted the compileWidgetAfter382 branch August 22, 2024 15:17
@sanason
Copy link
Contributor

sanason commented Aug 22, 2024

Doing so yielded the following diff. But it looks like that can all be ignored. Thoughts?

Yes, agreed. In particular, I have a USWDS PR out to prevent the changes in _widget-uswds.js.erb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sanason sanason sanason approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ryanwoldatwork @sanason