java-http/src/test/java/io/fusionauth/http/CookieTest.java at main · FusionAuth/java-http

History

425 lines (372 loc) · 15.9 KB

Raw

100

101

102

103

104

105

106

107

108

109

110

111

112

113

114

115

116

117

118

119

120

121

122

123

124

125

126

127

128

129

130

131

132

133

134

135

136

137

138

139

140

141

142

143

144

145

146

147

148

149

150

151

152

153

154

155

156

157

158

159

160

161

162

163

164

165

166

167

168

169

170

171

172

173

174

175

176

177

178

179

180

181

182

183

184

185

186

187

188

189

190

191

192

193

194

195

196

197

198

199

200

201

202

203

204

205

206

207

208

209

210

211

212

213

214

215

216

217

218

219

220

221

222

223

224

225

226

227

228

229

230

231

232

233

234

235

236

237

238

239

240

241

242

243

244

245

246

247

248

249

250

251

252

253

254

255

256

257

258

259

260

261

262

263

264

265

266

267

268

269

270

271

272

273

274

275

276

277

278

279

280

281

282

283

284

285

286

287

288

289

290

291

292

293

294

295

296

297

298

299

300

301

302

303

304

305

306

307

308

309

310

311

312

313

314

315

316

317

318

319

320

321

322

323

324

325

326

327

328

329

330

331

332

333

334

335

336

337

338

339

340

341

342

343

344

345

346

347

348

349

350

351

352

353

354

355

356

357

358

359

360

361

362

363

364

365

366

367

368

369

370

371

372

373

374

375

376

377

378

379

380

381

382

383

384

385

386

387

388

389

390

391

392

393

394

395

396

397

398

399

400

401

402

403

404

405

406

407

408

409

410

411

412

413

414

415

416

417

418

419

420

421

422

423

424

425

* Licensed under the Apache License, Version 2.0 (the "License");

* you may not use this file except in compliance with the License.

* You may obtain a copy of the License at

* http://www.apache.org/licenses/LICENSE-2.0

* Unless required by applicable law or agreed to in writing,

* software distributed under the License is distributed on an

* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,

* either express or implied. See the License for the specific

* language governing permissions and limitations under the License.

package io.fusionauth.http;

import java.net.CookieManager;

import java.net.HttpCookie;

import java.net.URI;

import java.net.http.HttpRequest;

import java.net.http.HttpResponse.BodySubscribers;

import java.nio.charset.StandardCharsets;

import java.time.ZoneOffset;

import java.time.ZonedDateTime;

import java.util.List;

import io.fusionauth.http.Cookie.SameSite;

import io.fusionauth.http.HTTPValues.Headers;

import io.fusionauth.http.server.CountingInstrumenter;

import io.fusionauth.http.server.HTTPHandler;

import io.fusionauth.http.server.HTTPServer;

import org.testng.annotations.Test;

import static org.testng.Assert.assertEquals;

import static org.testng.Assert.assertFalse;

import static org.testng.Assert.assertNull;

import static org.testng.Assert.assertTrue;

/**

* @author Brian Pontarelli

public class CookieTest extends BaseTest {

@Test

public void cookieInjection() throws Exception {

HTTPHandler handler = (req, res) -> {

assertNull(req.getCookie("injected"));

res.setHeader(Headers.ContentType, "text/plain");

res.setStatus(200);

res.getOutputStream().close();

};

try (HTTPServer ignore = makeServer("http", handler).start()) {

URI uri = URI.create("http://localhost:4242/%0d%0aSet-Cookie:injected=true%0d%0a?client_id=foo");

CookieManager cookieHandler = new CookieManager();

var client = makeClient("http", cookieHandler);

HttpRequest request = HttpRequest.newBuilder()

.uri(uri)

.GET()

.build();

var response = client.send(request, r -> BodySubscribers.discarding());

assertEquals(response.statusCode(), 200);

List<HttpCookie> cookies = cookieHandler.getCookieStore().get(uri);

assertEquals(response.statusCode(), 200);

assertNull(response.headers().firstValue("Set-Cookie").orElse(null));

assertEquals(cookies.size(), 0);

}

@Test

public void fromRequestHeader() {

List<Cookie> cookies = Cookie.fromRequestHeader("foo=bar; baz=fred");

assertEquals(cookies.size(), 2);

assertEquals(cookies.get(0), new Cookie("foo", "bar"));

assertEquals(cookies.get(1), new Cookie("baz", "fred"));

cookies = Cookie.fromRequestHeader("foo=bar==; baz=fred==");

assertEquals(cookies.size(), 2);

assertEquals(cookies.get(0), new Cookie("foo", "bar=="));

assertEquals(cookies.get(1), new Cookie("baz", "fred=="));

cookies = Cookie.fromRequestHeader("foo=; baz=");

assertEquals(cookies.size(), 0);

cookies = Cookie.fromRequestHeader("foo=");

assertEquals(cookies.size(), 0);

cookies = Cookie.fromRequestHeader("=");

assertEquals(cookies.size(), 0);

cookies = Cookie.fromRequestHeader("=bar");

assertEquals(cookies.size(), 0);

cookies = Cookie.fromRequestHeader(";");

assertEquals(cookies.size(), 0);

cookies = Cookie.fromRequestHeader(";;;;;");

assertEquals(cookies.size(), 0);

}

@SuppressWarnings("ConstantConditions")

@Test

public void fromResponseHeader() {

Cookie cookie = Cookie.fromResponseHeader("foo=bar; Path=/foo/bar; Domain=fusionauth.io; Max-Age=1; Secure; HttpOnly; SameSite=Lax");

assertEquals(cookie.domain, "fusionauth.io");

assertNull(cookie.expires);

assertTrue(cookie.httpOnly);

assertEquals((long) cookie.maxAge, 1L);

assertEquals(cookie.name, "foo");

assertEquals(cookie.path, "/foo/bar");

assertEquals(cookie.sameSite, Cookie.SameSite.Lax);

assertTrue(cookie.secure);

assertEquals(cookie.value, "bar");

cookie = Cookie.fromResponseHeader("foo=bar; Domain=fusionauth.io; Expires=Wed, 21 Oct 2015 07:28:00 GMT; SameSite=None");

assertEquals(cookie.domain, "fusionauth.io");

assertEquals(cookie.expires, ZonedDateTime.of(2015, 10, 21, 7, 28, 0, 0, ZoneOffset.UTC));

assertFalse(cookie.httpOnly);

assertNull(cookie.maxAge);

assertEquals(cookie.name, "foo");

assertNull(cookie.path);

assertEquals(cookie.sameSite, Cookie.SameSite.None);

assertFalse(cookie.secure);

assertEquals(cookie.value, "bar");

cookie = Cookie.fromResponseHeader(" foo=bar; \nDomain=fusionauth.io; \t Expires=Wed, 21 Oct 2015 07:28:00 GMT; \rSameSite=None");

assertEquals(cookie.domain, "fusionauth.io");

assertEquals(cookie.expires, ZonedDateTime.of(2015, 10, 21, 7, 28, 0, 0, ZoneOffset.UTC));

assertFalse(cookie.httpOnly);

assertNull(cookie.maxAge);

assertEquals(cookie.name, "foo");

assertNull(cookie.path);

assertEquals(cookie.sameSite, Cookie.SameSite.None);

assertFalse(cookie.secure);

assertEquals(cookie.value, "bar");

// Base 64 encoded with padding

cookie = Cookie.fromResponseHeader("foo=slkjsdoiuewljklk==");

assertNull(cookie.domain);

assertNull(cookie.expires);

assertFalse(cookie.httpOnly);

assertNull(cookie.maxAge);

assertEquals(cookie.name, "foo");

assertNull(cookie.path);

assertNull(cookie.sameSite);

assertFalse(cookie.secure);

assertEquals(cookie.value, "slkjsdoiuewljklk==");

// Broken but parseable

cookie = Cookie.fromResponseHeader("foo=bar;Domain=fusionauth.io;Expires=Wed, 21 Oct 2015 07:28:00 GMT;SameSite=None");

assertEquals(cookie.domain, "fusionauth.io");

assertEquals(cookie.expires, ZonedDateTime.of(2015, 10, 21, 7, 28, 0, 0, ZoneOffset.UTC));

assertFalse(cookie.httpOnly);

assertNull(cookie.maxAge);

assertEquals(cookie.name, "foo");

assertNull(cookie.path);

assertEquals(cookie.sameSite, Cookie.SameSite.None);

assertFalse(cookie.secure);

assertEquals(cookie.value, "bar");

// Empty values

cookie = Cookie.fromResponseHeader("foo=bar;Domain=;Expires=;SameSite=");

assertEquals(cookie.domain, "");

assertNull(cookie.expires);

assertFalse(cookie.httpOnly);

assertNull(cookie.maxAge);

assertEquals(cookie.name, "foo");

assertNull(cookie.path);

assertNull(cookie.sameSite);

assertFalse(cookie.secure);

assertEquals(cookie.value, "bar");

// Quoted value, no other attributes

// https://www.rfc-editor.org/rfc/rfc6265#section-4.1.1

// cookie-value = *cookie-octet / ( DQUOTE *cookie-octet DQUOTE )

cookie = Cookie.fromResponseHeader("foo=\"bar\";");

assertNull(cookie.domain);

assertNull(cookie.expires);

assertFalse(cookie.httpOnly);

assertNull(cookie.maxAge);

assertEquals(cookie.name, "foo");

assertNull(cookie.path);

assertNull(cookie.sameSite);

assertFalse(cookie.secure);

assertEquals(cookie.value, "bar");

// Quoted value, additional attribute

cookie = Cookie.fromResponseHeader("foo=\"bar\"; SameSite=");

assertNull(cookie.domain);

assertNull(cookie.expires);

assertFalse(cookie.httpOnly);

assertNull(cookie.maxAge);

assertEquals(cookie.name, "foo");

assertNull(cookie.path);

assertNull(cookie.sameSite);

assertFalse(cookie.secure);

assertEquals(cookie.value, "bar");

// Missing closing quote

// - This is not a valid value, but we are handling it anyway.

cookie = Cookie.fromResponseHeader("foo=\"bar; SameSite=");

assertNull(cookie.domain);

assertNull(cookie.expires);

assertFalse(cookie.httpOnly);

assertNull(cookie.maxAge);

assertEquals(cookie.name, "foo");

assertNull(cookie.path);

assertNull(cookie.sameSite);

assertFalse(cookie.secure);

assertEquals(cookie.value, "bar");

// Missing opening quote

// - This is not a valid value, but we are handling it anyway.

cookie = Cookie.fromResponseHeader("foo=bar\"; SameSite=");

assertNull(cookie.domain);

assertNull(cookie.expires);

assertFalse(cookie.httpOnly);

assertNull(cookie.maxAge);

assertEquals(cookie.name, "foo");

assertNull(cookie.path);

assertNull(cookie.sameSite);

assertFalse(cookie.secure);

assertEquals(cookie.value, "bar");

// Broken attributes

cookie = Cookie.fromResponseHeader("foo=bar; =fusionauth.io; =Wed, 21 Oct 2015 07:28:00 GMT; =1; =Lax");

assertNull(cookie.domain);

assertNull(cookie.expires);

assertFalse(cookie.httpOnly);

assertNull(cookie.maxAge);

assertEquals(cookie.name, "foo");

assertNull(cookie.path);

assertNull(cookie.sameSite);

assertFalse(cookie.secure);

assertEquals(cookie.value, "bar");

// Empty value cookie

cookie = Cookie.fromResponseHeader("a=");

assertNull(cookie.domain);

assertNull(cookie.expires);

assertFalse(cookie.httpOnly);

assertNull(cookie.maxAge);

assertEquals(cookie.name, "a");

assertNull(cookie.path);

assertNull(cookie.sameSite);

assertFalse(cookie.secure);

assertEquals(cookie.value, "");

// Empty value cookie

cookie = Cookie.fromResponseHeader("a=; Max-Age=1");

assertNull(cookie.domain);

assertNull(cookie.expires);

assertFalse(cookie.httpOnly);

assertEquals((long) cookie.maxAge, 1L);

assertEquals(cookie.name, "a");

assertNull(cookie.path);

assertNull(cookie.sameSite);

assertFalse(cookie.secure);

assertEquals(cookie.value, "");

// Empty values

// - Max-Age and Expires should never be empty

cookie = Cookie.fromResponseHeader("foo=;Domain=;SameSite=");

assertEquals(cookie.domain, "");

assertNull(cookie.expires);

assertFalse(cookie.httpOnly);

assertNull(cookie.maxAge);

assertEquals(cookie.name, "foo");

assertNull(cookie.path);

assertNull(cookie.sameSite);

assertFalse(cookie.secure);

assertEquals(cookie.value, "");

// Null values

cookie = Cookie.fromResponseHeader("foo;Domain;Expires;Max-Age;SameSite");

assertNull(cookie);

// Null values

cookie = Cookie.fromResponseHeader(" =bar; =fusionauth.io; =Wed, 21 Oct 2015 07:28:00 GMT; =1; =Lax");

assertNull(cookie);

// Null values at the start

cookie = Cookie.fromResponseHeader("=bar;=fusionauth.io;Expires;Max-Age;SameSite");

assertNull(cookie);

// Borked cookie

cookie = Cookie.fromResponseHeader("=;");

assertNull(cookie);

// Borked cookie

cookie = Cookie.fromResponseHeader(";");

assertNull(cookie);

// Borked cookie

cookie = Cookie.fromResponseHeader(";;;;;");

assertNull(cookie);

// Borked cookie

cookie = Cookie.fromResponseHeader("");

assertNull(cookie);

// Borked cookie

cookie = Cookie.fromResponseHeader("=");

assertNull(cookie);

// Borked cookie

cookie = Cookie.fromResponseHeader("=a");

assertNull(cookie);

// Borked coookie, ending with a semicolon;

cookie = Cookie.fromResponseHeader("foo=%2Fbar; Path=/; Secure; HTTPonly;");

assertNull(cookie.domain);

assertNull(cookie.expires);

assertTrue(cookie.httpOnly);

assertNull(cookie.maxAge);

assertEquals(cookie.name, "foo");

assertEquals(cookie.path, "/");

assertNull(cookie.sameSite);

assertTrue(cookie.secure);

assertEquals(cookie.value, "%2Fbar");

// additional attributes

// - name and value

cookie = Cookie.fromResponseHeader("foo=;utm=123");

assertEquals(cookie.name, "foo");

assertEquals(cookie.getAttribute("utm"), "123");

// additional attributes

// - name, sep but no value

cookie = Cookie.fromResponseHeader("foo=;utm=");

assertEquals(cookie.name, "foo");

assertEquals(cookie.getAttribute("utm"), "");

// additional attributes

// - name only

cookie = Cookie.fromResponseHeader("foo=;utm");

assertEquals(cookie.name, "foo");

assertEquals(cookie.getAttribute("utm"), "");

// additional attributes

// - multiple

cookie = Cookie.fromResponseHeader("foo=;foo=bar;bar=baz;bing=boom");

assertEquals(cookie.name, "foo");

assertEquals(cookie.getAttribute("foo"), "bar");

assertEquals(cookie.getAttribute("bar"), "baz");

assertEquals(cookie.getAttribute("bing"), "boom");

// has attribute

cookie = Cookie.fromResponseHeader("foo=;foo=bar;bar=baz;bing=boom");

assertTrue(cookie.hasAttribute("foo"));

assertTrue(cookie.hasAttribute("bar"));

assertTrue(cookie.hasAttribute("bing"));

assertFalse(cookie.hasAttribute("booya"));

assertFalse(cookie.hasAttribute("baz"));

assertFalse(cookie.hasAttribute("boom"));

}

@Test(dataProvider = "schemes")

public void roundTripMultiple(String scheme) throws Exception {

HTTPHandler handler = (req, res) -> {

assertEquals(req.getPath(), "/api/system/version");

assertEquals(req.getCookie("request").value, "request-value");

assertEquals(req.getCookie("request-2").value, "request-value-2");

res.addCookie(new Cookie("response", "response-value").with(c -> c.setSameSite(SameSite.Lax)));

res.addCookie(new Cookie("response-2", "response-value-2").with(c -> c.setMaxAge(42L)));

res.setStatus(200);

};

CountingInstrumenter instrumenter = new CountingInstrumenter();

try (HTTPServer ignore = makeServer(scheme, handler, instrumenter).start()) {

URI uri = makeURI(scheme, "");

CookieManager cookieHandler = new CookieManager();

var client = makeClient(scheme, cookieHandler);

var response = client.send(

HttpRequest.newBuilder().uri(uri).header(Headers.Cookie, "request=request-value").header(Headers.Cookie, "request-2=request-value-2").header(Headers.ContentType, "application/json").GET().build(),

r -> BodySubscribers.ofString(StandardCharsets.UTF_8)

);

List<HttpCookie> cookies = cookieHandler.getCookieStore().get(uri);

assertEquals(response.statusCode(), 200);

assertEquals(cookies.size(), 2);

assertEquals(cookies.stream().filter(c -> c.getName().equals("response")).findFirst().orElseThrow().getValue(), "response-value");

assertEquals(cookies.stream().filter(c -> c.getName().equals("response-2")).findFirst().orElseThrow().getValue(), "response-value-2");

assertTrue(response.headers().allValues("Set-Cookie").contains("response=response-value; SameSite=Lax"));

assertTrue(response.headers().allValues("Set-Cookie").contains("response-2=response-value-2; Max-Age=42"));

}

@Test(dataProvider = "schemes")

public void roundTripSingle(String scheme) throws Exception {

HTTPHandler handler = (req, res) -> {

assertEquals(req.getPath(), "/api/system/version");

assertEquals(req.getCookie("request").value, "request-value");

res.addCookie(new Cookie("response", "response-value").with(c -> c.setSameSite(SameSite.Lax)));

res.setStatus(200);

};

CountingInstrumenter instrumenter = new CountingInstrumenter();

try (HTTPServer ignore = makeServer(scheme, handler, instrumenter).start()) {

URI uri = makeURI(scheme, "");

CookieManager cookieHandler = new CookieManager();

var client = makeClient(scheme, cookieHandler);

var response = client.send(

HttpRequest.newBuilder().uri(uri).header(Headers.Cookie, "request=request-value").header(Headers.ContentType, "application/json").GET().build(),

r -> BodySubscribers.ofString(StandardCharsets.UTF_8)

);

List<HttpCookie> cookies = cookieHandler.getCookieStore().get(uri);

assertEquals(response.statusCode(), 200);

assertEquals(cookies.size(), 1);

assertEquals(cookies.get(0).getName(), "response");

assertEquals(cookies.get(0).getValue(), "response-value");

assertEquals(response.headers().firstValue("Set-Cookie").orElse(null), "response=response-value; SameSite=Lax");

}

@Test

public void toRequestHeader() {

assertEquals("foo=bar", new Cookie("foo", "bar").toRequestHeader());

}

Navigation Menu

Uh oh!

Uh oh!

FilesExpand file tree

CookieTest.java

Latest commit

History

CookieTest.java

File metadata and controls