src/components/base/store/checkout/shipping-address-form.tsx (1)

37-41: ⚠️ Potential issue | 🟠 Major

Call form.handleSubmit(); current handler is a no-op.

form.handleSubmit; only references the function, so submission/validation never runs after preventDefault. This breaks the form.

✅ Suggested fix

       onSubmit={(e) => {
         e.preventDefault();
         e.stopPropagation();
-        form.handleSubmit;
+        form.handleSubmit();
       }}

src/components/containers/store/accounts/wishlist/wishlist-list.tsx (1)

9-21: ⚠️ Potential issue | 🔴 Critical

Return the fallback UI to avoid null .map() crash.
Currently the NotFound block is evaluated but never returned, so the code continues and will throw if mockWishlists is null/undefined.

✅ Suggested fix

-  if (!mockWishlists) {
-    <div className="@container container mx-auto px-4 py-8">
+  if (!mockWishlists) {
+    return (
+      <div className="@container container mx-auto px-4 py-8">
         <NotFound
           title="Category not found"
           description="The category you're looking for doesn't exist or has been removed."
           icon={<ShoppingBag className="h-10 w-10 text-muted-foreground" />}
         >
           <Link to="/product">
             <Button variant="outline">Start Shopping</Button>
           </Link>
         </NotFound>
-    </div>;
+      </div>
+    );
   }

src/components/templates/store/category/category-detail-template.tsx (1)

45-56: ⚠️ Potential issue | 🟠 Major

Return the NotFound UI for missing categories.

Right now the JSX in the !category branch is not returned, so the NotFound view never renders and the component continues with category null. That yields a broken/blank experience.

✅ Suggested fix

   if (!category) {
-    <div className="@container container mx-auto px-4 py-8">
+    return (
+      <div className="@container container mx-auto px-4 py-8">
         <NotFound
           title="Category not found"
           description="The category you're looking for doesn't exist or has been removed."
           icon={<ShoppingBag className="h-10 w-10 text-muted-foreground" />}
         >
           <Link to="/category">
             <Button variant="outline">Browse All Categories</Button>
           </Link>
         </NotFound>
-    </div>;
+      </div>
+    );
   }

src/components/containers/shared/orders/order-table.tsx (2)

161-168: ⚠️ Potential issue | 🟡 Minor

onUpdateStatus receives current status, not a new status.

The callback is invoked with row.original.status (the current status), but the prop signature names this parameter newStatus. This is either a naming issue or a logic bug—typically "Update Status" would open a dialog to select a new status, then call the handler with that selection.

If the intent is to pass the current status for context, consider renaming the parameter to currentStatus in the interface to avoid confusion.

Option 1: Rename parameter if intent is to pass current status

-  onUpdateStatus?: (orderId: string, newStatus: string) => void;
+  onUpdateStatus?: (orderId: string, currentStatus: string) => void;

---

170-170: ⚠️ Potential issue | 🟡 Minor

"Download Invoice" has no click handler.

This menu item is rendered but does nothing when clicked—likely incomplete functionality.

Would you like me to open an issue to track implementing the invoice download functionality?

src/components/containers/store/checkout/checkout-order-summary.tsx (1)

19-36: ⚠️ Potential issue | 🔴 Critical

Critical: Missing return statement prevents empty state from rendering.

The empty cart condition creates a JSX element but doesn't return it. Execution continues to line 37, causing the full cart UI to render even when items.length === 0. Users will never see the empty state.

Note: This is a pre-existing bug not introduced by this PR, but it critically affects the user experience and should be fixed.

🐛 Proposed fix: Add return statement

   if (items.length === 0) {
-    <div className="rounded-lg border bg-background p-6 shadow-sm">
+    return (
+      <div className="rounded-lg border bg-background p-6 shadow-sm">
-      <h2 className="mb-6 font-semibold text-xl">Your Cart</h2>
-      <EmptyState
-        icon={<ShoppingBag className="h-10 w-10 text-muted-foreground" />}
-        title="No items yet"
-        description="Add items to your cart to continue with checkout."
-        action={
-          <Link to="/product">
-            <Button variant="outline" className="rounded-full">
-              Browse Products
-            </Button>
-          </Link>
-        }
-        className="py-8"
-      />
-    </div>;
+        <h2 className="mb-6 font-semibold text-xl">Your Cart</h2>
+        <EmptyState
+          icon={<ShoppingBag className="h-10 w-10 text-muted-foreground" />}
+          title="No items yet"
+          description="Add items to your cart to continue with checkout."
+          action={
+            <Link to="/product">
+              <Button variant="outline" className="rounded-full">
+                Browse Products
+              </Button>
+            </Link>
+          }
+          className="py-8"
+        />
+      </div>
+    );
   }

src/components/containers/shared/shipping/shipping-table.tsx (1)

70-106: ⚠️ Potential issue | 🟡 Minor

Empty dropdown menu when no actions are available.

When both canEdit and canDelete are false, the actions button still renders but opens an empty dropdown menu—this is confusing UX. Consider hiding the entire actions column or the menu trigger when no actions are permitted.

🛠️ Proposed fix: conditionally render actions cell

    {
      id: "actions",
      enableHiding: false,
      cell: ({ row }) => {
        const shippingMethod = row.original;
+        const hasActions = permissions.canEdit || permissions.canDelete;
+
+        if (!hasActions) return null;

        return (
          <DropdownMenu>

src/components/containers/shared/users/user-table.tsx (1)

153-155: ⚠️ Potential issue | 🟡 Minor

"View Details" menu item has no handler.

The item is rendered when permissions.canView is true but clicking it does nothing. Consider adding an onViewUser callback prop similar to onEditUser and onDeleteUser.

src/components/base/error/default-error-component.tsx (1)

84-88: ⚠️ Potential issue | 🟡 Minor

Verify Tailwind supports h-37.5 in production builds.

The h-37.5 class is not a standard Tailwind utility and won't be recognized without a custom theme extension. In production, this class will be dropped, causing the scroll area to expand unexpectedly. Use an arbitrary value instead:

✅ Recommended fix

-                    <ScrollArea className="mt-2 h-37.5 w-full rounded border bg-background/50 p-2 text-muted-foreground">
+                    <ScrollArea className="mt-2 h-[2.34375rem] w-full rounded border bg-background/50 p-2 text-muted-foreground">

biome.json (1)

39-56: ⚠️ Potential issue | 🟠 Major

Keep noDocumentCookie enabled to avoid normalizing unsafe patterns.
Turning this rule off makes it easier for document.cookie usage to creep in, which is a common XSS/CSRF risk vector. Prefer keeping the rule on and using a targeted suppression only where absolutely required.

Suggested adjustment

-        "noDocumentCookie": "off"
+        "noDocumentCookie": "warn"

src/components/containers/shared/users/add-user-dialog.tsx (1)

43-55: ⚠️ Potential issue | 🟠 Major

Missing validation for required fields.

The name and email fields are marked as required in the UI (with asterisks), but no validation is configured in the form. The form will submit successfully with empty values since @tanstack/react-form requires explicit validators.

🛡️ Proposed fix to add validation

   const form = useForm({
     defaultValues: {
       name: "",
       email: "",
       status: "active" as "active" | "inactive" | "suspended",
       avatar: null as FileList | null,
     },
+    validators: {
+      onSubmit: ({ value }) => {
+        const errors: Record<string, string> = {};
+        if (!value.name.trim()) {
+          errors.name = "Name is required";
+        }
+        if (!value.email.trim()) {
+          errors.email = "Email is required";
+        } else if (!/^[^\s@]+@[^\s@]+\.[^\s@]+$/.test(value.email)) {
+          errors.email = "Invalid email format";
+        }
+        return Object.keys(errors).length ? errors : undefined;
+      },
+    },
     onSubmit: async ({ value }) => {

Alternatively, add field-level validators for immediate feedback:

<form.Field 
  name="name"
  validators={{
    onChange: ({ value }) => !value.trim() ? "Name is required" : undefined,
  }}
>

src/components/templates/admin/admin-taxes-template.tsx (1)

36-40: ⚠️ Potential issue | 🔴 Critical

Missing import and incorrect component name for TaxTable.

The component used on line 36 is named TaxesTable (which doesn't exist), but the actual exported component from tax-table.tsx is named TaxTable. Additionally, the props passed to the component don't match its expected interface—TaxTable expects onDelete, onEdit, and onToggleActive callbacks, not permissions and onDeleteTax.

Correct the import and component name:

🐛 Import fix

 import { Plus } from "lucide-react";
 import { useState } from "react";
 import { AddTaxDialog } from "@/components/containers/shared/taxes/add-tax-dialog";
 import TaxHeader from "@/components/containers/shared/taxes/tax-header";
+import { TaxTable } from "@/components/containers/shared/taxes/tax-table";
 import { Button } from "@/components/ui/button";

Then update the component usage to match TaxTable's props signature.

src/components/containers/shared/transactions/transaction-table.tsx (1)

111-135: ⚠️ Potential issue | 🟡 Minor

Hide action items when handlers are missing.
With default permissions, users can see menu items that no-op if the handler isn’t provided.

🔧 Suggested guard

-              {permissions.canView && (
+              {permissions.canView && onViewTransaction && (
                 <DropdownMenuItem
                   onClick={() => onViewTransaction?.(transaction.id)}
                 >
                   <Eye className="mr-2 h-4 w-4" />
                   View Details
                 </DropdownMenuItem>
               )}
-              {permissions.canRefund &&
+              {permissions.canRefund &&
+                onRefundTransaction &&
                 transaction.paymentStatus === "paid" && (
                   <DropdownMenuItem
                     onClick={() => onRefundTransaction?.(transaction.id)}
                   >
                     <RefreshCcw className="mr-2 h-4 w-4" />
                     Refund
                   </DropdownMenuItem>
                 )}
-              {permissions.canDelete && (
+              {permissions.canDelete && onDeleteTransaction && (
                 <DropdownMenuItem
                   onClick={() => onDeleteTransaction?.(transaction.id)}
                   className="text-destructive"
                 >
                   <Trash2 className="mr-2 h-4 w-4" />
                   Delete
                 </DropdownMenuItem>
               )}

src/components/containers/shared/shops/add-shop-dialog.tsx (2)

49-64: ⚠️ Potential issue | 🟠 Major

Submission result not awaited — dialog closes prematurely on async errors.

The onSubmit callback supports Promise<void>, but its result is not awaited. If the parent's submission fails (e.g., network error), the dialog will have already closed and reset the form, preventing error feedback to the user.

🐛 Proposed fix

     onSubmit: async ({ value, formApi }) => {
       await formApi.validateAllFields("blur");
       await formApi.validateAllFields("change");

       const hasErrors = Object.values(formApi.state.fieldMeta).some(
         (meta) => meta?.errors && meta.errors.length > 0
       );

       if (hasErrors) {
         return;
       }

-      onSubmit(value);
-      onOpenChange(false);
-      form.reset();
+      await onSubmit(value);
+      onOpenChange(false);
+      form.reset();
     },

---

28-36: ⚠️ Potential issue | 🟡 Minor

Unused isSubmitting prop.

The isSubmitting prop is declared in the interface but never destructured or used. Either remove it from the interface or wire it into the form's submission state.

🧹 Option A: Remove unused prop

 interface AddShopDialogProps {
   open: boolean;
   onOpenChange: (open: boolean) => void;
   onSubmit: (data: ShopFormValues) => void | Promise<void>;
-  isSubmitting?: boolean;
 }

src/components/base/data-table/data-table-container.tsx (1)

93-104: ⚠️ Potential issue | 🟡 Minor

Handle empty array filter values (Line 100).
Empty multi-selects (e.g., []) will still be pushed as active filters. Consider treating empty arrays as “no filter” to prevent unintended filtering.

💡 Suggested fix

-        if (value !== "" && value !== undefined && value !== null) {
+        const isEmpty =
+          value === "" ||
+          value === undefined ||
+          value === null ||
+          (Array.isArray(value) && value.length === 0);
+        if (!isEmpty) {
           filtered.push({ id: columnId, value });
         }