Skip to content

Add MQTT Mutual Auth on QEMU demo - #936

Open
ydhuang28 wants to merge 20 commits into
FreeRTOS:mainfrom
ydhuang28:main
Open

Add MQTT Mutual Auth on QEMU demo#936
ydhuang28 wants to merge 20 commits into
FreeRTOS:mainfrom
ydhuang28:main

Conversation

@ydhuang28

Copy link
Copy Markdown
Contributor

Add MQTT Mutual Auth on QEMU demo

Description

Adds a demo for MQTT Mutual Auth on QEMU.

Test Steps

n/a (see README.md in demo folder for instructions to build and test)

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

n/a

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ydhuang28
ydhuang28 requested a review from a team as a code owner February 23, 2023 20:23
jasonpcarroll
jasonpcarroll previously approved these changes Feb 24, 2023
@ydhuang28

Copy link
Copy Markdown
Contributor Author

The files in include/CMSIS is the CMSIS pack for the Cortex M4, and thus not authored by us.

@AniruddhaKanhere AniruddhaKanhere left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ydhuang28 for this PR.
I have a few comments - can you please take a look?

Thanks,

Comment thread FreeRTOS-Plus/Demo/MQTT_Mutual_Auth_Qemu_mps2/source/main.c
Comment thread FreeRTOS-Plus/Demo/MQTT_Mutual_Auth_Qemu_mps2/source/main.c Outdated
Comment thread FreeRTOS-Plus/Demo/MQTT_Mutual_Auth_Qemu_mps2/source/main_networking.c Outdated
Comment thread FreeRTOS-Plus/Demo/MQTT_Mutual_Auth_Qemu_mps2/source/startup.c Outdated
Comment thread FreeRTOS-Plus/Demo/MQTT_Mutual_Auth_Qemu_mps2/source/startup.c Outdated

@AniruddhaKanhere AniruddhaKanhere left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ydhuang28,
Apologies for a very delayed review. Can you please take a look at some of the minor corrections that I have suggested?

Thank you!

Comment thread FreeRTOS-Plus/Demo/MQTT_Mutual_Auth_Qemu_mps2/source/main.c Outdated
Comment thread FreeRTOS-Plus/Demo/MQTT_Mutual_Auth_Qemu_mps2/source/main.c Outdated
Comment thread FreeRTOS-Plus/Demo/MQTT_Mutual_Auth_Qemu_mps2/source/startup.c Outdated
Comment thread FreeRTOS-Plus/Demo/MQTT_Mutual_Auth_Qemu_mps2/source/startup.c Outdated
@kar-rahul-aws

Copy link
Copy Markdown
Contributor

/bot run formatting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants