ledmatrix: Limit max brightness, and do custom brightness control #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new hardware is extremely bright, so we need to limit the brightness. We limit it so that the max power consumption is slightly under 500mA. This limit is done by using the scaling factor in the LED controller. This also has the advantage that we have more brightness levels available for each LED because we can use the full range (previously much of the range would be too bright to use, even with the first hardware revision). But since we can't use the scaling factor for brightness control anymore, we have to do the brightness calculation ourselves. Signed-off-by: Daniel Schaefer <dhs@frame.work>
JohnAZoidberg
force-pushed
the
max-brightness
branch
from
8d9d708 to
bdf3e9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new hardware is extremely bright, so we need to limit the brightness.
We limit it so that the max power consumption is slightly under 500mA. This limit is done by using the scaling factor in the LED controller.
This also has the advantage that we have more brightness levels available for each LED because we can use the full range (previously much of the range would be too bright to use, even with the first hardware revision).
But since we can't use the scaling factor for brightness control anymore, we have to do the brightness calculation ourselves.