Skip to content

Conversation

@JohnAZoidberg
Copy link
Member

So that the vcruntime DLL is built in and runs on freshly installed windows systems.

So that the vcruntime DLL is built in and runs on freshly installed windows systems.

Signed-off-by: Daniel Schaefer <dhs@frame.work>
More efficient. Highlighted by new clippy lint:

```
error: calling `as_bytes` after slicing a string
   --> framework_lib/src/chromium_ec/mod.rs:919:45
    |
919 |         request.name[..end].copy_from_slice(name[..end].as_bytes());
    |                                             ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&name.as_bytes()[..end]`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#sliced_string_as_bytes
    = note: `-D clippy::sliced-string-as-bytes` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::sliced_string_as_bytes)]`
```

Signed-off-by: Daniel Schaefer <dhs@frame.work>
@JohnAZoidberg JohnAZoidberg merged commit 70d6649 into main Apr 10, 2025
6 checks passed
@JohnAZoidberg JohnAZoidberg deleted the win-release branch April 10, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants