Add support for RGB command #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnAZoidberg
force-pushed
the
rgbkbd
branch
5 times, most recently
from
fecda01 to
04e8b09
Compare
amstan
reviewed
Mar 4, 2025
amstan
reviewed
Mar 4, 2025
amstan
reviewed
Mar 4, 2025
| ); | ||
| } else { | ||
| let start_key = args.rgbkbd[0] as u8; | ||
| let colors = args.rgbkbd[1..].iter().map(|color| RgbS { |
There was a problem hiding this comment.
bonus points if you figure out how to do the *8 multipliers like i have on the ec console.
Member
Author
There was a problem hiding this comment.
left as an exercise for the reader
Member
Author
There was a problem hiding this comment.
ohh like ws2812 on the console, ectool or rgbkbd also doesn't have this
amstan
reviewed
Mar 4, 2025
Only code formatting difference. Signed-off-by: Daniel Schaefer <dhs@frame.work>
Signed-off-by: Daniel Schaefer <dhs@frame.work>
Works like this: ``` > cargo build && sudo ./target/debug/framework_tool --rgbkbd 0 16711680 65280 255 ``` Signed-off-by: Daniel Schaefer <dhs@frame.work>
Signed-off-by: Daniel Schaefer <dhs@frame.work>
``` sudo framework_tool --rgbkbd 0 0xFF0000 0x00FF00 0x0000FF ``` Signed-off-by: Daniel Schaefer <dhs@frame.work>
Signed-off-by: Daniel Schaefer <dhs@frame.work>
Member
Author
|
FreeBSD build failing for CI reasons, ignoring that. |
Member
Author
|
Tested on Framework Desktop, can work fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yes, called rgbkbd because of the host command and to match ectool.
But we are actually planning to use it for the Framework Deskop's ARGB header (with fans, etc.)
For example: