Deprecated: Foolz\SphinxQL\SphinxQL::__construct(): Implicitly markin… #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g parameter $connection as nullable is deprecated Fixes FoolCode#214
|
The inspection completed: No new issues |
Contributor
Member
|
This looks reasonable, I could merge it but I wouldn't be able to publish a new package. Would that be helpful? |
Contributor
|
I think it'd be a step in the right direction. If need be, we can fall back on this GitHub repo as the package source. |
Contributor
|
These changes look reasonable and I merged in the other. Ideally, would like to find maintainers for this project or point others to a maintained fork. I can try looking at getting a new version published, but might take some time as it's been a few years since I've touched this project and don't work with PHP these days. |
oohnoitz
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g parameter $connection as nullable is deprecated
Fixes #214