-
Notifications
You must be signed in to change notification settings - Fork 99
Add PHP 8 support and drop PHP 7.0 and lower #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks! Tested it on my code, works good. |
|
@oohnoitz Can you merge it? |
|
Does the multi-select query with the show meta helper work for you on this thread? $result = (new SphinxQL($this->conn)) For some reason, I don't have meta information as a result. I am using sphinx 3.3.1, php8, laravel8. |
|
@nikonor909 it works in If you want to try version from this PR, add this to your "repositories": [
{
"type": "vcs",
"url": "https://github.com/ben221199/sphinxql-query-builder"
}
],
"require": {
...
"foolz/sphinxql-query-builder": "dev-php8",
...
}Not recommended for production, obviously. |
|
@red-led thanks. |
|
Looks good to me. We'll want to update the CHANGELOG @ben221199 and mark this as 3.0.0 release. Once that is done, I'll merge and tag the release. |
|
Ok, I will do this now. |
|
The inspection completed: No new issues |
|
@oohnoitz, can we expect 3.0 release on packagist? |
This Pull Requests adds PHP 8 support with working tests and drops support for PHP 7.0 and lower.