Skip to content

Conversation

@ben221199
Copy link
Contributor

This Pull Requests adds PHP 8 support with working tests and drops support for PHP 7.0 and lower.

This was referenced Apr 11, 2021
@red-led
Copy link
Contributor

red-led commented Apr 12, 2021

Thanks! Tested it on my code, works good.
Looking forward for a new release with this changes.

@ben221199
Copy link
Contributor Author

@oohnoitz Can you merge it?

@nikonor909
Copy link

Does the multi-select query with the show meta helper work for you on this thread?

$result = (new SphinxQL($this->conn))
->select()
->from('rt')
->where('gid', 9003)
->enqueue((new Helper($this->conn))->showMeta())

For some reason, I don't have meta information as a result. I am using sphinx 3.3.1, php8, laravel8.

@red-led
Copy link
Contributor

red-led commented Apr 13, 2021

@nikonor909 it works in ben221199:php8 branch, but does not in FoolCode:php8.

If you want to try version from this PR, add this to your composer.json:

  "repositories": [
    {
      "type": "vcs",
      "url": "https://github.com/ben221199/sphinxql-query-builder"
    }
  ],
  "require": {
...
    "foolz/sphinxql-query-builder": "dev-php8",
...
  }

Not recommended for production, obviously.

@nikonor909
Copy link

@red-led thanks.

@oohnoitz
Copy link
Contributor

Looks good to me. We'll want to update the CHANGELOG @ben221199 and mark this as 3.0.0 release. Once that is done, I'll merge and tag the release.

@ben221199
Copy link
Contributor Author

Ok, I will do this now.

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@oohnoitz oohnoitz merged commit 9a6d504 into FoolCode:master Apr 13, 2021
@red-led
Copy link
Contributor

red-led commented Apr 20, 2021

@oohnoitz, can we expect 3.0 release on packagist?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants