Repository navigation
Conversation
Flarette
force-pushed
the
feat/ignored-binding-errors
branch
from
November 8, 2026 13:17
0b5ef33 to
9f8a914
Compare
Report bindings that <ng-container>, <ng-template>, and <ng-content> ignore as errors, since they never take effect. - NG8031 (`ignoredBinding`) is now an error by default. While it's on, NG8030 skips <ng-container>, so each ignored event is reported once. - NG0319 now throws under `errorOnUnknownProperties`, like NG0303. BREAKING CHANGE: Bindings that have no effect are now errors With strictTemplates, a binding that <ng-container>, <ng-template>, or <ng-content> ignores, or a static attribute on them that nothing reads, now fails to compile with NG8031. This includes property bindings on <ng-container> under NO_ERRORS_SCHEMA. Tests that use `errorOnUnknownProperties` now fail on NG0319. Each error points at a binding that never had an effect. Remove the binding, move it to an element, or add the directive that claims it to the component's imports. To report NG8031 as a warning while you migrate, set `extendedDiagnostics.checks.ignoredBinding` to `"warning"`.
Flarette
force-pushed
the
feat/ignored-binding-errors
branch
from
November 8, 2026 15:45
9f8a914 to
7248746
Compare
This was referenced Nov 8, 2026
Owner
Author
|
Superseded by the upstream PRs angular#71882, angular#71883, and angular#71884. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1. Review only the last commit; the first one is #1.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
After #1, NG8031 is a warning, and NG0319 only logs, even under
errorOnUnknownProperties. Anunclaimed event on
<ng-container>gets both NG8030 (withstrictUnclaimedEventNames) and NG8031.Issue Number: N/A (issue draft not posted yet)
What is the new behavior?
This changes severities only; what gets reported stays as in #1.
<ng-container>, so each ignoredevent gets one error.
errorOnUnknownProperties, like NG0303.Does this PR introduce a breaking change?
With
strictTemplates, a binding or static attribute that NG8031 reports stops compiling,including a property binding on
<ng-container>underNO_ERRORS_SCHEMA. Each error points at abinding that never had an effect.
Tests that use
errorOnUnknownPropertiesfail on NG0319.Migration: remove the binding, move it to an element, or import the directive that claims it. To
report NG8031 as a warning while migrating, set
extendedDiagnostics.checks.ignoredBindingto"warning".Other information
ng_projecttargets in this repo build with this change.