Skip to content

V3beta - Python improvements #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: v3beta
Choose a base branch
from
Open

V3beta - Python improvements #567

wants to merge 13 commits into from

Conversation

@M4RC0Sx
Copy link

@M4RC0Sx M4RC0Sx commented Oct 26, 2022

This PR covers the following aspects:

  • Use PEP8 format in all files, style improvements.
  • Migration to Pipenv in order to improve dependency management and local development environment with dev dependencies and .env management provided by Pipenv.
  • Implemented a custom FlareSolverr logger to avoid having to disable all libraries loggers.

@HLFH
Copy link

HLFH commented Jan 3, 2023

@M4RC0Sx Have you added pyproject.toml in this PR? PEP 517
If not, you should as it will help packaging for GNU/Linux distributions.

@ngosang ngosang mentioned this pull request Jan 5, 2023
Open
@ngosang ngosang added this to the 3.1.0 milestone Jan 5, 2023
@ngosang ngosang modified the milestones: 3.1.0, 3.2.0 Mar 20, 2023
@Asthowen Asthowen mentioned this pull request May 3, 2024
Closed
@Smart123s Smart123s mentioned this pull request Oct 31, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngosang ngosang Awaiting requested review from ngosang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@M4RC0Sx @HLFH @ngosang