Skip to content

Remove extra newline in readline_timed(). #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pcisar merged 2 commits into from
Nov 17, 2025
Merged

Remove extra newline in readline_timed(). #59

pcisar merged 2 commits into from
Nov 17, 2025

Conversation

@fdcastel
Copy link
Member

@fdcastel fdcastel commented Nov 17, 2025 •
edited
Loading

Fix for #58.

Running the demonstration script (newline-problem.py) after this fix generates both files correctly.

raw-trace-fbtracemgr.txt:

2025-11-16T21:37:16.6010 (57764:0000000002500D40) ATTACH_DATABASE
	C:\PROGRAM FILES\FIREBIRD\FIREBIRD_3_0\EXAMPLES\EMPBUILD\EMPLOYEE.FDB (ATT_99, SYSDBA:NONE, NONE, XNET:)
	C:\Users\fdcastel.TOLKIEN\AppData\Roaming\uv\python\cpython-3.11.11-windows-x86_64-none\python.exe:26704

2025-11-16T21:37:16.6010 (57764:0000000002500D40) START_TRANSACTION
	C:\PROGRAM FILES\FIREBIRD\FIREBIRD_3_0\EXAMPLES\EMPBUILD\EMPLOYEE.FDB (ATT_99, SYSDBA:NONE, NONE, XNET:)
	C:\Users\fdcastel.TOLKIEN\AppData\Roaming\uv\python\cpython-3.11.11-windows-x86_64-none\python.exe:26704
		(TRA_189, CONCURRENCY | WAIT | READ_WRITE)

2025-11-16T21:37:16.6010 (57764:0000000002500D40) EXECUTE_STATEMENT_START
	C:\PROGRAM FILES\FIREBIRD\FIREBIRD_3_0\EXAMPLES\EMPBUILD\EMPLOYEE.FDB (ATT_99, SYSDBA:NONE, NONE, XNET:)
	C:\Users\fdcastel.TOLKIEN\AppData\Roaming\uv\python\cpython-3.11.11-windows-x86_64-none\python.exe:26704
		(TRA_189, CONCURRENCY | WAIT | READ_WRITE)

raw-trace-python3-driver.txt:

2025-11-16T21:37:20.8960 (57764:0000000002500D40) ATTACH_DATABASE
	C:\PROGRAM FILES\FIREBIRD\FIREBIRD_3_0\EXAMPLES\EMPBUILD\EMPLOYEE.FDB (ATT_102, SYSDBA:NONE, NONE, XNET:)
	C:\Users\fdcastel.TOLKIEN\AppData\Roaming\uv\python\cpython-3.11.11-windows-x86_64-none\python.exe:26704

2025-11-16T21:37:20.8970 (57764:0000000002500D40) START_TRANSACTION
	C:\PROGRAM FILES\FIREBIRD\FIREBIRD_3_0\EXAMPLES\EMPBUILD\EMPLOYEE.FDB (ATT_102, SYSDBA:NONE, NONE, XNET:)
	C:\Users\fdcastel.TOLKIEN\AppData\Roaming\uv\python\cpython-3.11.11-windows-x86_64-none\python.exe:26704
		(TRA_190, CONCURRENCY | WAIT | READ_WRITE)

2025-11-16T21:37:20.8990 (57764:0000000002500D40) EXECUTE_STATEMENT_START
	C:\PROGRAM FILES\FIREBIRD\FIREBIRD_3_0\EXAMPLES\EMPBUILD\EMPLOYEE.FDB (ATT_102, SYSDBA:NONE, NONE, XNET:)
	C:\Users\fdcastel.TOLKIEN\AppData\Roaming\uv\python\cpython-3.11.11-windows-x86_64-none\python.exe:26704
		(TRA_190, CONCURRENCY | WAIT | READ_WRITE)

@pcisar pcisar merged commit 4c8e6b1 into FirebirdSQL:master Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fdcastel @pcisar