Updated location specific pricing for hw create-options #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com/FernandoOjeda/softlayer-python into FernandoOjeda-fo_vs_create_options_order_item_list
…rking. Still needs testing
Author
|
errr... not sure why this shows 60 files updated, I guess your branch here isn't updated with master or something? |
….com/FernandoOjeda/softlayer-python into FernandoOjeda-fo_vs_create_options_order_item_list
Author
|
There we go, looks fixed now :) |
Owner
|
yep hehe. |
FernandoOjeda
merged commit 8bfd858
into
FernandoOjeda:fo_vs_create_options_order_item_list
allmightyspiff
deleted the
FernandoOjeda-fo_vs_create_options_order_item_list
branch
FernandoOjeda
pushed a commit
that referenced
this pull request
Jun 9, 2021
add new email features, email detail and email edit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I wanted location specific pricing to just update on the list, but that turns out to be super complicated. I did get it working I think, but I could use your help getting the code compliant with
tox, and unit tested. And actual tested, to make sure the math matches what the portal shows.Some big changes in the hardware manager:
get_item_priceand_get_preset_costchanged up to accept locations, and a lot of if statements to get it working right.get_create_optionsto check that the input DC (using shortname now, since that is what create-options shows) is a real datacenter