Skip to content

fixed bug where all events had to have handlers in hooks #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fixed bug where all events had to have handlers in hooks #193

wants to merge 1 commit into from

Conversation

@jdpigeon
Copy link
Contributor

@jdpigeon jdpigeon commented Nov 11, 2022

I was trying to use the hooks option to set some logic today and discovered that the typing is wrong currently and requires handlers to be provided for ALL event types if using this option:

// ...
        hooks: {
          run: eventHandler,
        },
// Throwing error related to missing ""before:prepare", prepare, render, end", etc.
// ...

This type change allows the previous code to be valid

@jdpigeon
Copy link
Contributor Author

jdpigeon commented Nov 11, 2022

Unlike most index signatures, I think this requires all instances of EventName to be present specifically because the index signature is an enum

@gdevenyi gdevenyi mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jdpigeon