Skip to content

Jackson-3 Support @JsonInclude in Collection #5370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JooHyukKim wants to merge 11 commits into
base: 3.x
Choose a base branch
from
Open

Jackson-3 Support @JsonInclude in Collection #5370

JooHyukKim wants to merge 11 commits into from
+978 −41

Conversation

@JooHyukKim
Copy link
Member

@JooHyukKim JooHyukKim commented Oct 29, 2025

resolves #5369

@JooHyukKim
Copy link
Member Author

JooHyukKim commented Dec 3, 2025

Lemme know if there's anything I can improve on

@cowtowncoder
Copy link
Member

cowtowncoder commented Dec 4, 2025

@JooHyukKim Sorry, been swamped with introspection bug fixes; this is still on my todo list to review soon. :)

@cowtowncoder
Copy link
Member

cowtowncoder commented Dec 4, 2025

Ok, so added a note on issue: I think we have to add a feature (probably MapperFeature) to allow opt-in of this functionality since it seems to have backwards compatibility risks.

@JooHyukKim
Copy link
Member Author

JooHyukKim commented Dec 7, 2025

Added SerializationFeature.APPLY_JSON_INCLUDE_FOR_COLLECTIONS(false), name TBD :-)

@github-actions
Copy link

github-actions bot commented Dec 20, 2025

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 78.59% 📉 -0.170%
Branches branches 72.22% 📉 -0.280%

Coverage data generated from JaCoCo test results

@github-actions
Copy link

github-actions bot commented Dec 20, 2025

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 78.59% 📉 -0.180%
Branches branches 72.22% 📉 -0.310%

Coverage data generated from JaCoCo test results

cowtowncoder
cowtowncoder reviewed Dec 20, 2025
View reviewed changes
src/test/java/tools/jackson/databind/ser/filter/JsonIncludeForCollection5369Test.java
import static org.junit.jupiter.api.Assertions.assertEquals;

// [databind#5369] Support `@JsonInclude` for collection
public class JsonIncludeForCollection5369Test
Copy link
Member

@cowtowncoder cowtowncoder Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, but will also need to cover more of types:

  • Object[]
  • String[]

to exercise ObjectArraySerializer and StringArraySerializer respectively.

And maybe non-String List (like List<Integer> or such)?

@cowtowncoder
Copy link
Member

cowtowncoder commented Dec 20, 2025

Looks good overall; needs bit more test coverage. But also looks like some deprecated methods/constructors are being called (as per IDE warnings), probably need to change to either:

  1. Change call to non-deprecated method
  2. Mark caller itself deprecated (like when overriding deprecated method).

Anyway I hope to do proper review soon: but I like how PR is getting ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cowtowncoder cowtowncoder cowtowncoder left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support @JsonInclude for Collection

2 participants

@JooHyukKim @cowtowncoder