Replies: 6 comments 19 replies
-
|
Hi @rohitab, I'll try replying one by one. May not have enough time tonight to address all issues. If so, I'll continue tomorrow or on the weekend. Please bear with me. Annotations Highlighting
I am trying to understand the scenario. What is the purpose of inserting an item which does not contain the found text? That aside, I think that I should clear annotations only if I clear complex user data. Something like this: if (NewItem->Item.Flags&LIF_DELETEUSERDATA)
{
Item.ComplexUserData = {};
Item.Annotations.clear();
}I am not sure why I did not do it right away, likely because I did not exactly understand the scenarios where As an aside, I have plans to remove annotations altogether and provide them on the fly based on the complex user data. Then the issue will naturally disappear. |
Beta Was this translation helpful? Give feedback.
-
|
@MKadaner take your time replying. No rush!
This particular issue is not about inserting a new item, but about modifying an existing item that contains annotations. I'm adding a checkmark to the current line so that I can easily locate it within the list of items. Adding a checkmark should not delete the annotations. Now regarding inserting an item. When I need to search, I select a word then press
That would work. |
Beta Was this translation helpful? Give feedback.
-
|
I pushed #1008. Please see how it works (when it is merged). Thank you for the explanation. I did something similar when I crafted |
Beta Was this translation helpful? Give feedback.
-
|
Thank you. Since I already tested this before, it should work. But, once the release is available, I will test again and let you know. |
Beta Was this translation helpful? Give feedback.
-
Line and Column NumbersAgain, I do not understand the scenario. While your script apparently works, I would not bet that something is not broken when you meddle with the content of the Find All menu. Think about At the higher level of abstraction, scripts should not depend on undocumented features, like particular layout of Find All menu items. Let me quote @alabuzhev (#952 (comment)):
This discussion about another script actually prompted the implementation of In this light, the Circling back, what is your scenario? Could it be supported in another, not so intrusive way? |
Beta Was this translation helpful? Give feedback.
-
No problem at all. No need to apologize. Since I wrote the script and have been using it for a while now, I assumed what I was doing was straightforward and easy to understand.
I understand this. In fact, these are cases that I'm already handling. For example, you added a new feature to copy items to the editor using
If the list is required to be sorted, then it's on the script developer to ensure that the list is sorted. I'm willing to make all these changes. All I need is some kind of API that allows me to do so.
One of the best features I like about Far is the ease of customization. I've written close to a 100 scripts that customize and add features to Far. If restrictions were put in place to prevent customizations, it would have a negative impact on users.
That would be great.
Of course, and that's expected. If something breaks because of the changes I made, that's on me to fix.
I think the menu text should return whatever is displayed on the menu. For example, take the Code pages menu (Editor
I think they should be sorted by line numbers and position default, just like they are today, but you could always add a feature to sort by a different columns 😛 (p.s., I'm not asking for this feature).
True, but like you said earlier: "All menus and dialogs are subject to change without any notice". I guess it's on the script developer to update the script to account for the changes. |
Beta Was this translation helpful? Give feedback.
-
I do not fully agree. While it may be very convenient, such messing with the internal object's state can easily break its invariant. Generally speaking, if such intrusive behavior is not allowed, the object's implementation can be simpler. Putting it the other way around, if some data can be modified by two entities (in this case, the Editor and a script), both must be fully prepared to deal with any mess at any time. This entails proper defensive programming, which is way harder than what I sometimes do in Far. P.S. The lack of this defensive approach in many modern software systems is the main reason for their proverbial poor quality.
It's the same question at a slightly different angle. With the fixed columns, the menu does not display the contents of items exactly. For example, the number of characters reserved in the item's text for position is fixed and is very large (was 6; 10 after #1012 is merged), however, the "position" column is displayed in as few columns as actually required; leading whitespaces are ignored. Next, if the fixed columns are hidden, are they "displayed?" Line / position are metadata, not part of the item's content. They should not (and soon will not) be returned by P.S. As for the Code pages menu, I have not gotten to it yet. 😀 |
Beta Was this translation helpful? Give feedback.
-
I don't know how it's implemented internally, but from a users/scripting point of view, there should be some consistency. All other menus return the same data that is displayed. The Find all results menu returns something different. Given the line content
Previously, the content matched, not to mention that proper separators were used. In the new version, the column and text are merged together and even Anyway, this discussion isn't going anywhere, so consider this closed.
If it ain't broke, don't fix it |
Beta Was this translation helpful? Give feedback.
-
Sorry again for jumping in, but 100 is an impressive number! Can you please make me a favor and give a brief summary of what kind of customizations and features these are? I don't recollect seeing you sharing any at the Forum… P.S. Oops, the same sentiment has already been added earlier. |
Beta Was this translation helpful? Give feedback.
-
As I tried to explain, with the introduction of the fixed columns in the Find All menu, this "consistency" is inherently broken. Please open the menu and press Currently, the strange conglomerate of some numbers and the text string is returned. It's wrong. I am working on returning the text string stripped off the metadata. |
Beta Was this translation helpful? Give feedback.
-
Selecting TextAs I tried to explain above, depending on the content of the Find All menu items is asking for trouble.
I wrote the You are more than welcome to reuse this technique (and the implementation) in your script and do not bother about performance in this scenario. P.S. Unrelated. Are you aware of the new Find All menu feature, ( |
Beta Was this translation helpful? Give feedback.
-
Sounds good.
Yes! Excellent feature. I've used it already. |
Beta Was this translation helpful? Give feedback.
-
Sorry for jumping in, but I cannot help making a note that performance of a Debug (that is, unoptimized) build is not indicative of a Release (optimized) build at all. (To be precise, it is a crude one-sided estimate.) Since it is a Release build that constitutes the product, and any Debug build is just an intermediate aimed to help developers, I would pay no attention to Debug performance (apart from being able to get the work done) and would not recommend spending any effort measuring/profiling that. |
Beta Was this translation helpful? Give feedback.
-
To be clear, I did not try to measure anything on debug build, even less to optimize.
My point here is that binary search in a collection of several thousand items implemented in Lua is fast. I intentionally compared it against creating the same collection, which is implemented in C++ and intentionally used debug build so that the time would be noticeable at all. I did not mean any measurements, just tried to demonstrate that binary search in Lua (over all these API layers) is quite acceptable replacement of the linear search (actually any linear operation) in C++. |
Beta Was this translation helpful? Give feedback.
-
Column VisibilityPlease open a separate feature request. Let's have a proper discussion. Personally, I would not implement a Lua API for such a niche functionality. Saving the last state of the columns should not be difficult, but I am not sure the maintainer will bless even this, and I will not insist. Again, personally, I do not feel I need preserving the state here. With the columns taking much less screen real estate, I use |
Beta Was this translation helpful? Give feedback.
-
|
Forget about this. It was just a discussion, which is why I didn't create any bug reports or enhancement requests. |
Beta Was this translation helpful? Give feedback.
-
|
To summarize, in this topic we are left only with |
Beta Was this translation helpful? Give feedback.
-
Sounds interesting. Wouldn't you mind to share them? |
Beta Was this translation helpful? Give feedback.
-
|
Most of the scripts I've written are for customizing Far based on my needs. I'm not sure how many of those will be useful for others.
Lots of other minor customizations like hotkeys for inserting ISO dates in dialogs, signatures in editor, reloading files, toggling user-defined suffix for files/folders while preserving date/time, Hex/RegEx conversion in search dialogs, switching between alternative/current/original paths while saving/extracting files. Autocomplete.mp4 |
Beta Was this translation helpful? Give feedback.
-
|
That is an impressive example of what looks like a long-term semi-isolated development! |
Beta Was this translation helpful? Give feedback.
-
|
Thanks! I had planned on making some of these available, but never got around to it. |
Beta Was this translation helpful? Give feedback.
-
|
I see how it can be hard and time-consuming to prepare the whole bulk of scripts for publication. |
Beta Was this translation helpful? Give feedback.
-
|
That's a good idea, but my preference would be to just get everything done at once, all the macros, scripts, viewers and syntaxes. Hopefully, it shouldn't take long once I get started. If it does, I'll definitely consider publishing them in batches. I just realized that it's already been a month since I posted that. Time flies. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
I have a Lua script that customizes the Find all results menu. I just updated my script to account for the recent changes. However, there are still a few issues remaining.
Annotations Highlighting
My script modifies the menu to indicate the current line by adding a checkmark to it. If the current line is already present, it adds a checkmark to that line, otherwise it inserts a new line and adds a checkmark to it. Here are screenshots from both old and new versions.
Old Version
New Version
As you can see, in the new version, the annotations in the current line
3427are missing. The issue appears to be due to the following code inVMenu::UpdateItem, which clears the annotations when an item is updated usingDM_LISTUPDATE.FarManager/far/vmenu.cpp
Line 992 in 96d48b7
For testing, I commented out the above code and the issue was resolved.
Line and Column Numbers
In the previous dialog design, there was a fixed amount of space allocated for line and column numbers. As a result, when a new line was added, that had a line number with more digits than the existing lines, it was displayed properly. Here are screenshots from both old and new versions.
Old Version
New Version
As you can see, in the current version, the line number of the inserted line, which is
3772is not displayed fully (the first digit is missing). The actual content of the menu item is"3772 struct test_data". In cases where the inserted line has the same number or fewer digits than existing lines, this issue is not present.One way to fix this issue might be to expose an API
Menu.SetItemExtendedDatathat allows extended menu data to be set. This API would be similar to theMenu.GetItemExtendedDataAPI that is currently available for retrieving extended menu data.Another way to fix this might be to format the menu text (using separators for example) so that the menu handler can extract the columns from the text. In the old version, the menu text matched what was displayed on the screen.
Old Version: Menu.Value
211:6 │ + need_check_mark()New Version: Menu.Value
211 6 + need_check_mark()Selecting Text
In the previous version, if you wanted to select the menu item with line number
246, you could use the following code:Similarly, you could use
Menu.Select("246:28", 1)to select a matching line/column, if there were multiple matches within a single line. Unfortunately, this cannot be used reliably with the current design, especially if the text starts with a number. As a result, you have to iterate over all the items, retrieve extended data, and compare the line and column/position of each item, which can be slow if there are a large number of items in the menu.Column Visibility
This is not a big deal, but I think it would be useful to have a way to get/set column visibility via a Lua API. Alternatively, if the state can be saved/restored, that would work too.
@MKadaner tagging you since you are the main developer, and thank you for all the effort you have put to improve the Find all results menu.
Beta Was this translation helpful? Give feedback.
All reactions